Issue: using build number instead of semver about keel

[rusenask]

That's a bug then :/ will fix it.

…

On Sun, Jul 30, 2017, 7:38 PM Mark Janssen ***@***.***> wrote: I've tried this, but it doesn't work: time="2017-07-30T18:27:08Z" level=info msg="provider.kubernetes: delta changed applied: application:42.0.0" i.e. keel deploys 42.0.0 instead of the correct 42 tag. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#67 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIqNKeQK0WAo1VavfoA4PUn38g1apQdzks5sTM22gaJpZM4Onq5r> .

[praseodym]

Thank you! We've upgraded to 0.4.4 and it works great.

[rusenask]

hey, there was similar issue with polling trigger, fix was just (12 minutes ago) merged in 0.4.5 :)

[rusenask]

You can use force policy with webhooks so it will always update once new image is available.

[praseodym]

I've tried this, but it doesn't work:

time="2017-07-30T18:27:08Z" level=info msg="provider.kubernetes: delta changed applied: application:42.0.0"

i.e. keel deploys 42.0.0 instead of the correct 42 tag.

[rusenask]

So the problem was this https://github.com/Masterminds/semver/blob/master/version.go#L54-L93. It treats emptiness as zeroes and I actually couldn't find a good reason to remove this. It's not semver but this behaviour actually lets you use major policy to incrementally update your application. Fixes are in the master branch and will be released with some other new features. Meanwhile I started alpha tag build, that image with fix should be available shortly.

[praseodym]

Thank you, I'll give the alpha tag a try.

[rusenask]

This is definitely merged and is available from 0.4.3.

[praseodym]

I just noticed and upgraded 😄

[rusenask]

good, very agile :D