GithubHelp home page GithubHelp logo

Comments (11)

dustinlarimer avatar dustinlarimer commented on June 12, 2024

@gfpacheco thanks for reporting -- where exactly is this interval set?

from keen-tracking.js.

dustinlarimer avatar dustinlarimer commented on June 12, 2024

Perhaps here? https://github.com/keen/keen-tracking.js/blob/master/lib/utils/timer.js#L14

from keen-tracking.js.

gfpacheco avatar gfpacheco commented on June 12, 2024

Here actually

from keen-tracking.js.

dustinlarimer avatar dustinlarimer commented on June 12, 2024

Ahh yeah, that makes sense. Thanks for your help. I'll find a fix for this.

from keen-tracking.js.

dustinlarimer avatar dustinlarimer commented on June 12, 2024

The queue is accessible at client.queue. I could expose a simple method to clear or stop that interval. Would that do the trick?

from keen-tracking.js.

gfpacheco avatar gfpacheco commented on June 12, 2024

Yes, that would do the job!

from keen-tracking.js.

philkunz avatar philkunz commented on June 12, 2024

normal exiting is like a mandatory feature...

from keen-tracking.js.

dustinlarimer avatar dustinlarimer commented on June 12, 2024

@gfpacheco I have a PR ready for this: #80. If you wouldn't mind giving it a quick glance I'd love to hear your thoughts on the update. Hopefully this addresses all the requirements you're looking for.

Thank you so much for helping me spot this issue, and apologies for the time you lost debugging this! Any other suggestions or observations you care to share would be super helpful 🚀

from keen-tracking.js.

dustinlarimer avatar dustinlarimer commented on June 12, 2024

@philkunz you're totally right, super bummed to see a bug like this sneak out 😞

from keen-tracking.js.

gfpacheco avatar gfpacheco commented on June 12, 2024

That's great! I just tested and it works just fine.

from keen-tracking.js.

dustinlarimer avatar dustinlarimer commented on June 12, 2024

Awesome! Happy to hear that 😀

from keen-tracking.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.