Client `smoke-test` command about keep-core

[l3x]

Regarding installing urfave/cli ... We can avoid any unexpected compatibility pains once v2 becomes master, by pinning it to v1 like so:

$ go get gopkg.in/urfave/cli.v1

and in our source files:

...
import (
  "gopkg.in/urfave/cli.v1" 
)
...

Or should we just specify the version in Gopkg.lock and keep our source cleaner looking?

...
import (
  "gopkg.in/urfave/cli" 
)
...

[Shadowfiend]

For now let’s specify in Gopkg. We will actually need to fork it and pin to a commit, but we can wait a little if we want to let the newer version advance in the meantime.

If we intend on using an existing version, then let’s fork and pin to the current master HEAD commit.

[Shadowfiend]

@l3x can you make sure to pull this into the appropriate column in the GH project?

[l3x]

I added the following to the .toml file, which pins urfave/cli to a specific revision hash and points the source to our forked repo:

Gopkg.toml

[[constraint]]
  name = "github.com/urfave/cli"
  revision = "8e01ec4cd3e2d84ab2fe90d8210528ffbb06d8ff"
  source = "https://github.com/keep-network/cli.git"

When I ran dep ensure the following was added to the .lock file:

Gopkg.lock

[[projects]]
  name = "github.com/keep-network/cli"
  packages = ["."]
  revision = "cfb38830724cc34fedffe9a2a29fb54fa9169cd1"
  version = "v1.20.0"

[[projects]]
  name = "github.com/urfave/cli"
  packages = [
    ".",
    "altsrc"
  ]
  revision = "8e01ec4cd3e2d84ab2fe90d8210528ffbb06d8ff"
  source = "https://github.com/keep-network/cli.git"

Is that what you're talking about?

[Shadowfiend]

Yeah that looks good to me 👍

[l3x]

Thanks!