1.0.2 broke freebsd about dns-lookup

[Erk-]

Seems that it is missing in libc as far as I can tell from man getnameinfo FreeBSD does support NI_NUMERICSERV.

[Erk-]

I have made a pr to libc to fix the issue so we can wait for upstream to be merged.
rust-lang/libc#1768

[keeperofdakeys]

Thanks for letting me know. In this case it's probably best to wait till this has been fixed upstream.

In the mean time it looks like Travis CI now has freebsd support (or will have). I'll have a look into getting this enabled on this repo. travis-ci/travis-build#1780

Did you run a git bisect? I don't have access to a freebsd machine at the moment, and this would help verify the reason it's failing.

[Erk-]

The reason it is failing is that NI_NUMERICSERV is not exposed to FreeBSD in libc which my patch above fixes. So it broke in the 59e8743 commit. I fixed it locally and it worked, but it seems I have to fix the patch up a bit so it does not fail on older versions of freebsd.

[Erk-]

This will be fixed with the next release of libc to use it now you can try out patching the dependency.

[patch.crates-io]
libc = { git = "https://github.com/rust-lang/libc.git" }

[keeperofdakeys]

I've added freebsd to travisci, so hopefully we'll catch any issues with freebsd in the future. Since the libc crate appears to be doing a release every few weeks I'll leave this open till the next release, and test/verify when it's released.

If you need freebsd support now then hardcoding 1.0.1 is fine, the only feature packaged in 1.0.2 is the gethostname change.

[Erk-]

@keeperofdakeys The new version have been released so could I get you to rerun the tests and then close this if it works.

[keeperofdakeys]

Thanks, travisci is now passing. I've pushed 1.0.3 with no changes, because I don't actually know if crates.io enforces subversions or not. Either way it should be good now.