GithubHelp home page GithubHelp logo

Comments (5)

Kephson avatar Kephson commented on June 19, 2024

Hi @tomashavner thanks for reporting; I will check it and release a new version if I could fix it.

from paste_reference.

tomashavner avatar tomashavner commented on June 19, 2024

Hi,

If you replace
OnReady.setSelectOptionFromExternalSource = setFormValueFromBrowseWin = function (elementId, tableUid) {
tableUid = tableUid.replace('tt_content_', '') * 1;
DragDrop.default.onDrop(tableUid, $('#' + elementId).find('.t3js-paste-new'), 'copyFromAnotherPage');
}
with:
require(['TYPO3/CMS/Backend/Utility/MessageUtility'], function (MessageUtility) {
window.addEventListener('message', function (e) {

        if (!MessageUtility.MessageUtility.verifyOrigin(e.origin)) {
            throw 'Denied message sent by ' + e.origin;
        }

        if (typeof e.data.fieldName === 'undefined') {
            throw 'fieldName not defined in message';
        }

        if (typeof e.data.value === 'undefined') {
            throw 'value not defined in message';
        }

        const result = e.data.value;
        var tableUid = result.replace('tt_content_', '') * 1;
        var elementId = e.data.fieldName;
        DragDrop.default.onDrop(tableUid, $('#' + elementId).find('.t3js-paste-new'), 'copyFromAnotherPage');
    });
});

paste_reference/Resources/Public/JavaScript/PasteReferenceOnReady.js will work.
BUT there is a bug in paste_reference/Resources/Public/JavaScript/PasteReferenceDragDrop.js as well:
You have to replace line 169:
var $pasteElement = typeof Paste.itemOnClipboardUid === 'number' ? Paste.itemOnClipboardUid : $draggableElement;
with:
var $pasteElement = $draggableElement;
if(typeof Paste.itemOnClipboardUid === 'number' && Paste.itemOnClipboardUid > 0) {
$pasteElement = Paste.itemOnClipboardUid;
}
the reason is that 0 also is a number.

Kind regards

Tomas

from paste_reference.

Kephson avatar Kephson commented on June 19, 2024

Hi thanks, I checked your changes, but there is still a problem:
If you want to insert content from another page (and having elements in clipboard) it will always insert content from the clipboard and not the selected element.
I'm trying to find the problem. Please check latest main commit.

from paste_reference.

tomashavner avatar tomashavner commented on June 19, 2024

Hi,
Replace
var $pasteElement = $draggableElement;
if(typeof Paste.itemOnClipboardUid === 'number' && Paste.itemOnClipboardUid > 0) {
$pasteElement = Paste.itemOnClipboardUid;
}
with
if($draggableElement) {
var $pasteElement = $draggableElement;
} else if(typeof Paste.itemOnClipboardUid === 'number') {
var $pasteElement = Paste.itemOnClipboardUid;
}

from paste_reference.

Kephson avatar Kephson commented on June 19, 2024

Thanks, I updated the script and tested it successfull. Released new version 2.0.2 of the extension.

from paste_reference.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.