GithubHelp home page GithubHelp logo

Comments (4)

kettanaito avatar kettanaito commented on May 25, 2024

The fix is published in 0.16.2. Could you please update and let me know if that worked? Thanks.

from atomic-layout.

hallaji avatar hallaji commented on May 25, 2024

@kettanaito Apparently, this works only if we narrow down the value type to primitive types. Otherwise, the setValue in useEffect results in an infinite loop (e.g. a value type such as a react node or element).

Imagine you switch to a new locale, a new default value and breakpoints object will be passed in. So I think we need a sort of side effect to update the breakpoints for useBreakpointChange.

from atomic-layout.

kettanaito avatar kettanaito commented on May 25, 2024

@hallaji hey, thanks for following with this. Can this issue be solves by using something like useDeepCompareEffect?

from atomic-layout.

hallaji avatar hallaji commented on May 25, 2024

not quite sure. I'll take a look.

from atomic-layout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.