kevinconway / event.js Goto Github PK

Calling emit with arguments always passes undefined as the first argument.

  EventMixin.prototype.emit = function emit(event) {

    var listenerArgs = [],
      length = arguments.length,
      x,
      numberListeners,
      remove = [];

    // This loop is not right as it leaves listenerArgs[0] as undefined
    for (x = 1; x < length; x = x + 1) {
      listenerArgs[x] = arguments[x];
    }

The fix is trivial:

    for (x = 0; x < length - 1; x++) {
      listenerArgs[x] = arguments[x+1];
    }

Hope this helps.

Hi,
I'm trying to setup eventjs to include in browser, but was not able to configure successfully.

HTML:

eventjs after build using grunt:
lib\event.browser.min.js

main.js:
var EventEmit = require(['./lib/event.browser.min']);
var EventEmitter = new EventEmit();

EventEmitter.emit('start'); //-->>> failed no emit function.