GithubHelp home page GithubHelp logo

Comments (8)

KevinVandy avatar KevinVandy commented on June 1, 2024 2

@MarekPatyna It seems that the full locale name is ukUA from my understanding. That's what Material UI itself names their locale. And usually its fine to just refer to it by the first 2 letters, unless there are multiple dialects.

image

I always refer to this website when checking: https://saimana.com/list-of-country-locale-code/

image

from material-react-table.

MarekPatyna avatar MarekPatyna commented on June 1, 2024 1

Thank you for your reply. Unfortunately but I did not see that Ukrainian was created because I was sure that "uk" corresponds to United Kingdom. In my opinion and from what I checked on the internet the ISO abbreviation for Ukrainian is UA or possibly UKR but not UK.

https://www.andiamo.co.uk/resources/iso-language-codes/
https://laendercode.net/en/country/ua
https://www.iso.org/obp/ui/#iso:code:3166:UA
https://en.wikipedia.org/wiki/ISO_3166-2:UA

from material-react-table.

KevinVandy avatar KevinVandy commented on June 1, 2024 1

@MarekPatyna Your translations seem to be a lot different than the current uk locale in MRT. Which one is more correct? The existing one or yours?

image

from material-react-table.

KevinVandy avatar KevinVandy commented on June 1, 2024

Yeah for sure, just make a PR in the same format as the current uk locale`.
https://github.com/KevinVandy/material-react-table/blob/v2/packages/material-react-table/src/locales/uk.ts

btw, what's the difference between uk and ua?

from material-react-table.

MarekPatyna avatar MarekPatyna commented on June 1, 2024

I don't speak Ukrainian at b2/c1+ level, so I would personally suggest leaving the current translation. Thanks for the quick replies and good luck with MRT development!

from material-react-table.

imnasnainaec avatar imnasnainaec commented on June 1, 2024

I always refer to this website when checking: https://saimana.com/list-of-country-locale-code/

And if a language isn't there, its more comprehensive source is https://iso639-3.sil.org/code_tables/639/data.

from material-react-table.

imnasnainaec avatar imnasnainaec commented on June 1, 2024

Thank you for your reply. Unfortunately but I did not see that Ukrainian was created because I was sure that "uk" corresponds to United Kingdom. In my opinion and from what I checked on the internet the ISO abbreviation for Ukrainian is UA or possibly UKR but not UK.

https://www.andiamo.co.uk/resources/iso-language-codes/
https://laendercode.net/en/country/ua
https://www.iso.org/obp/ui/#iso:code:3166:UA
https://en.wikipedia.org/wiki/ISO_3166-2:UA

@MarekPatyna To clarify, the ISO 3166-2 code you were seeing for Ukraine (UA) is the country code, not the language code: https://en.wikipedia.org/wiki/ISO_3166#Parts

from material-react-table.

MarekPatyna avatar MarekPatyna commented on June 1, 2024

Apologies for writing back so late but I completely forgot about this issue. Thank you again @imnasnainaec @KevinVandy for your help.

Best regards!

from material-react-table.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.