Comments (2)
Hi,
thanks for your hint!
I'm already using a "ready function" (https://github.com/kevinweber/wbounce/blob/master/frontend/class-frontend.php#L82). So I don't know what I should change to solve your issue. Feel free to send a working pull request.
Have you tried the plugin's option "Load script in footer"? You find it on the options page of the plugin.
Best regards,
Kevin
from wbounce.
Hey,
Sorry I was not clear in the first message. The problem come from the fact that the ready function need jquery and jquery is loaded after. In the footer the order is:
your modal
your modal javascript (the one that use the ready function)
jquery
modernizr, bootstrap, etc
I assume you hook to the start of the footer (when the option is selected in the option panel) and add your code. I fixed it by replacing the jQuery ready function with a plain and pure JavaScript "ready" function. I will send you a pull request Monday when I'm at work or this weekend if I ever get time to set up a wamp stack and a fresh WordPress (just re installed windows). It's gonna be easier to see what I'm talking about.
Honestly I don't think it affects a lot of people. We used Roots starter theme to create our own and I think it messes up with your plugin when all scripts are loaded in the footer.
Beside that, nice plugin, even if I don't like sites that use popup like that haha. I'm not the one choosing what we do, so for what it does, it does it well.
Thank you,
BT
from wbounce.
Related Issues (10)
- No option to disable popup on ext HOT 2
- Exclude pages/posts/or page template HOT 4
- Fire only after first page load HOT 1
- no option to animate popup? HOT 5
- wBounce content is applying the short code filter HOT 1
- Custom Post type support? HOT 1
- Default status "Home page" HOT 1
- Do not display pop-up when certain conditions are met
- Be able to translate the popup content with WPML HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wbounce.