Is `node-webcrypto-ossl` a dependency still? about isomorphic-webcrypto

[kevlened]

Thanks for finding this! I'm surprised nobody hit this since Sept. It's fixed in 2.3.5.

[CxRes]

Thank you! Could you please also add an engines property to package.json, since @peculiar/webcrypto is meant for node 10 and above.

[kevlened]

Are you running into an issue where this is necessary? Anything below 10 is deprecated.

I'm hesitant, because I'm unsure how various bundlers treat this field.

[CxRes]

Not an issue as such but I was trying to target node 8.0+ (Did not realize it is no longer maintained since Jan 2020).

I am also hitting these problems while bundling an old piece of code. Its just good to have npm warn me about incompatibility in advance...

[kevlened]

Got it. The downstream library includes the `engines` field, which npm/yarn *should* warn about. https://github.com/PeculiarVentures/webcrypto/blob/master/package.json#L89

…

On Tue, Feb 25, 2020 at 15:37 CxRes ***@***.***> wrote: Not an issue as such but I was trying to target node 8.0+ (Did not realize it is no longer maintained since Jan 2020). I am also hitting these problems while bundling an old piece of code. Its just good to have npm warn me about incompatibility in advance... — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#27?email_source=notifications&email_token=AAHJHMDNSD4MVOLQ6NFUPMDREWTVJA5CNFSM4K3UQUTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM6BBNQ#issuecomment-591138998>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHJHMF6FKWIPNGS6D2KTXLREWTVJANCNFSM4K3UQUTA> .