GithubHelp home page GithubHelp logo

Comments (5)

Drodt avatar Drodt commented on June 19, 2024

It seems that settings in general are not saved. Changing the appearance or font size also gets lost.

from key.

Drodt avatar Drodt commented on June 19, 2024

I seem to have found the point where it goes wrong (using the extension example):

  1. ExtensionSettings are added to ProofIndependentSettings
  2. The lastReadedProperties are read to extract extension settings
  3. Reading is done by AbstractPropertiesSettings#readSettings(Properties)
  4. It looks for key "disabled" to get disabled extensions
  5. Disabled extensions are actually under Extensions > disabled in the JSON file
  6. No property for "disabled" is found; use default

I think the JSON file is not properly read and reading it as Properties seems incorrect. Iirc, @wadoon implemented this. I am not familiar enough to change it.

from key.

unp1 avatar unp1 commented on June 19, 2024

@Drodt Thanks for looking into it!

from key.

FliegendeWurst avatar FliegendeWurst commented on June 19, 2024

I fixed the particular case of not being able to disable extensions in #3392

from key.

FliegendeWurst avatar FliegendeWurst commented on June 19, 2024

This is fixed now that #3392 is merged

from key.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.