Support environment variables? about keystone-storage-adapter-s3

[josephg]

Yeah I was wondering about that while writing it. The test suite uses environment variables.

I think generally it should be up to the application to configure the S3 options. The question is between writing:

var storage = new keystone.Storage({
    adapter: require('keystone-s3'),
    s3: {
        key: process.env.S3_KEY,
        secret: process.env.S3_SECRET,
        bucket: process.env.S3_BUCKET,
    },
})

... or leaving that out. Tbh I can't think of any strong reason to leave it out - if you want to manually configure those properties you can either not specify environment variables or just override them in your configuration.