Validation isn't always triggered about archetype

[kjac]

Weird! I'm stuck in Copenhagen without my laptop (whine!) but if I'm not completely mistaken I was the last one to mess about with the property validators... I'll have a look at it tomorrow when I get home :-)

[kjac]

Ok this is more nasty than I thought.

The validation IS actually triggered, but for some reason the validation result is ignored by Umbraco, and the submit proceeds as if nothing happened.

What's worse... validation of nested Archetypes does not work at all. Looks like the validation needs a redo. I'll submit a PR soon with a suggestion on how to solve both issues.

First tho', we need to decide on how to perform validation. @kgiszewski maybe you want to weigh in here too :)

Archetype currently validates the property editors while the editor is entering data, thus giving an immediate feedback on the validity of the property. A consequence of this is that the invalid properties are highlighted immediately upon page load.

The "Umbraco way" of validating is to let the editor enter whatever they want and perform validation on submit. This obviously does not give an immediate feedback to the editor, but on the upside it leaves all property editors in their valid appearance until submit, which one might argue is a nicer editing experience?

So... do we stick with the Archetype way of doing validation (immediate feedback and a bunch of red property editors) or do we adopt the Umbraco way of doing it? In my opinion we should do it the Umbraco way, even if the immediate feedback is a nice feature.

On a side note, the last commit (4785c85) seems to have broken the validation highlighting of invalid fieldsets and property editors?

[kjac]

Submitted PR #137 to handle this.

[kjac]

By the looks of things, this should be fixed with v1.2. I think :)

[rmillo8]

Hi, I noticed that validation now only works for the last field.

If the first (or second, etc..) field is required, and left empty, the page will be published.
If the last field is required, and left empty, the page will prompt a "Property has errors" message.

I have Archetype latest 1.4.1 version.

[kgiszewski]

@kjac @tomfulton Any chance the alias names might be at play here?

[kjac]

Hmm it used to work just fine. I'll have a look at it when I get home next
week.
On 6 Aug 2014 16:41, "Kevin Giszewski" [email protected] wrote:

@kjac https://github.com/kjac @tomfulton https://github.com/tomfulton
Any chance the alias names might be at play here?

—
Reply to this email directly or view it on GitHub
#131 (comment).