GithubHelp home page GithubHelp logo

Comments (4)

jeresig avatar jeresig commented on May 18, 2024

It looks like you only ever have two types of hints - regardless of the name. Why not just simplify it and reduce it to two names/divs for substitution?

I'm hesitant to remove empty elements as it's possible that there might be a need for actually having an empty element (let's say a div that's styled to look like a circle, or something).

from khan-exercises.

osnr avatar osnr commented on May 18, 2024

Hmm. If we fix #37, though, there will be three hints on the inheriting problem types. So some problems (the base types) will have two hints and others will have three hints, and the base types will still encounter this issue.

Could we mark empty elements in problem-specific hints as skippable?

from khan-exercises.

sophiebits avatar sophiebits commented on May 18, 2024

You can still have hint1, hint2, hint3, and leave hint3 blank if you want and that would work.

Perhaps the current hint inheritance system doesn't make that much sense and it would be better to have more of a include-type thing where you need to specify all the hints for every problem but you can share specific hints if you want. (Like the current way where it copies, but the other way around.)

from khan-exercises.

jeresig avatar jeresig commented on May 18, 2024

direct-variation has:
relationship
fits

v1-over-v2 has:
transform
fits

inverse-k has:
transform
fits

inverse-variation has:
relationship
fits

v1-v2-over-k has:
transform
fits

k-over-a has:
transform
fits

Currently the hint block looks like this:

<div class="hints">
    <p class="relationship"></p>
    <p class="transform"></p>
    <p class="fits"></p>
</div>

Just change it to:

<div class="hints">
    <p class="relationship-or-transform"></p>
    <p class="fits"></p>
</div>

And update all the relationship or transform hints to use the relationship-or-transform class instead.

from khan-exercises.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.