GithubHelp home page GithubHelp logo

Comments (6)

khoih-prog avatar khoih-prog commented on July 20, 2024

@marcelstoer

Can you un-comment this Line 1715 from

//stopConfigPortal = true; //signal ready to shutdown config portal		//KH crash if use this ???

to

stopConfigPortal = true; //signal ready to shutdown config portal		//KH crash if use this ???

to see if that is what you expect.

Possibly I forgot to un-comment after tested last time.

from espasync_wifimanager.

marcelstoer avatar marcelstoer commented on July 20, 2024

Indeed, that's the behavior I would expect. Thanks! In fact, on iOS the config portal window/dialog closes so quickly now that you don't even get to see the /close response "page". Not that I would care about it anyway 😄 Important is that the portal is shut down and that works nicely now.

from espasync_wifimanager.

khoih-prog avatar khoih-prog commented on July 20, 2024

That's good. Will update in next release.

from espasync_wifimanager.

marcelstoer avatar marcelstoer commented on July 20, 2024

Can I ask you to keep issues open until the respective fix has landed on master? That would allow us to be notified by GitHub when we can update our dependencies.

from espasync_wifimanager.

khoih-prog avatar khoih-prog commented on July 20, 2024

Master updated.

from espasync_wifimanager.

khoih-prog avatar khoih-prog commented on July 20, 2024

See ESP_WiFiManager v1.2.0 and Contributions-and-Thanks

Releases v1.2.0

  1. Restore cpp code besides Impl.h code to use in case of multiple definition linker error. See Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h and Support building in PlatformIO PR. Also have a look at HOWTO Fix Multiple Definitions Linker Error
  2. Fix bug /close does not close the config portal.

from espasync_wifimanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.