Comments (6)
Agreed, unix should be last in the if-else sequence. Sorry we missed this.
It can be conflated, eglPlatform.h should be only indicating the default. That reordering seems OK.
I think it was supposed that the compiler would know the platform and and the macro set. But with multiple support there maybe many combinations of which goes first.
Do you want to propose a change to eglPlatform.h? The MR should be limited to just this change.
from egl-registry.
Yes, I can propose a change.
from egl-registry.
The "__unix__" clause seems like its a catch all for any undefined window system on a linux/unix platform. Jon may remember some history on this.
from egl-registry.
I have a vague recollection of initially using some comparable set of ifdefs from Mesa headers. That was a long time ago.
from egl-registry.
I think we'll need a couple of reviewers, so to check that we haven't inadvertently broke some platform. Especially around QNX, Wayland, Unix. where the change will touch.
from egl-registry.
#192 is merged.
Closing issue
from egl-registry.
Related Issues (20)
- Depth/stencil EGL image HOT 27
- how can I build and install EGL-Registry on linux os ? HOT 3
- Broken link on start.html page HOT 8
- EGL cross-vendor Display Timing / Presentation timing extension for Linux HOT 5
- EXT_image_dma_buf_import format enumeration HOT 8
- [EGL-Registry mismatch with EGL spec] Why the default value of EGL_GL_COLORSPACE on eglCreatePBufferSurface has gap between EGL spec with this EGL-Registry ? HOT 2
- Possibly missing xcb extension? HOT 7
- /usr/bin/ld: cannot find -lEGL HOT 5
- eglCreateImage for cubemap textures HOT 12
- eglCreateContext attrib_list documentation is confusing HOT 3
- eglCreatePlatform{Window,Pixmap}Surface documentation should mention EGL 1.5 dependency HOT 2
- Does EGL_KHR_display_reference overspecify the default state? HOT 4
- `EGL_EXT_image_dma_buf_import`: advertise which hints are supported HOT 3
- eglCompositorSwapPolicyEXT mismatch between header and description HOT 2
- Broken contact details for EGL_EXT_surface_SMPTE2086_metadata and EGL_EXT_surface_CTA861_3_metadata HOT 8
- Query context reset notification strategy HOT 12
- opengl HOT 1
- New HOT 1
- Color management on EGL Wayland platform HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from egl-registry.