GithubHelp home page GithubHelp logo

Comments (6)

stonesthrow avatar stonesthrow commented on June 23, 2024

Agreed, unix should be last in the if-else sequence. Sorry we missed this.

It can be conflated, eglPlatform.h should be only indicating the default. That reordering seems OK.

I think it was supposed that the compiler would know the platform and and the macro set. But with multiple support there maybe many combinations of which goes first.

Do you want to propose a change to eglPlatform.h? The MR should be limited to just this change.

from egl-registry.

jmcdonnell-blackberry avatar jmcdonnell-blackberry commented on June 23, 2024

Yes, I can propose a change.

from egl-registry.

stonesthrow avatar stonesthrow commented on June 23, 2024

The "__unix__" clause seems like its a catch all for any undefined window system on a linux/unix platform. Jon may remember some history on this.

from egl-registry.

oddhack avatar oddhack commented on June 23, 2024

I have a vague recollection of initially using some comparable set of ifdefs from Mesa headers. That was a long time ago.

from egl-registry.

stonesthrow avatar stonesthrow commented on June 23, 2024

I think we'll need a couple of reviewers, so to check that we haven't inadvertently broke some platform. Especially around QNX, Wayland, Unix. where the change will touch.

from egl-registry.

stonesthrow avatar stonesthrow commented on June 23, 2024

#192 is merged.
Closing issue

from egl-registry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.