GithubHelp home page GithubHelp logo

Comments (16)

fabrobinet avatar fabrobinet commented on August 17, 2024

currently blocked by KhronosGroup/OpenCOLLADA#112

from gltf.

fabrobinet avatar fabrobinet commented on August 17, 2024

This should be better already, but I'll make a full check.

from gltf.

pjcozzi avatar pjcozzi commented on August 17, 2024

@fabrobinet can we close this?

from gltf.

fabrobinet avatar fabrobinet commented on August 17, 2024

I need to double-check

from gltf.

pjcozzi avatar pjcozzi commented on August 17, 2024

I need to double-check

Can we close this?

from gltf.

fabrobinet avatar fabrobinet commented on August 17, 2024

no, still need to review all 3d entities and make sure they have the right ids.

from gltf.

fabrobinet avatar fabrobinet commented on August 17, 2024

need to fix for animations - dev-8.

from gltf.

pjcozzi avatar pjcozzi commented on August 17, 2024

need to fix for animations - dev-8.

Was this fixed?

from gltf.

pjcozzi avatar pjcozzi commented on August 17, 2024

CC #235 (propagate names)

from gltf.

pjcozzi avatar pjcozzi commented on August 17, 2024

@fabrobinet do you recall?

need to fix for animations - dev-8.

Was this fixed?

from gltf.

pjcozzi avatar pjcozzi commented on August 17, 2024

@tfili can you evaluate this when your looking at name propagation (#235)?

from gltf.

tfili avatar tfili commented on August 17, 2024

Just a quick look, the following look correct
COLLADA geometry -> glTF mesh
Lights
Cameras
Nodes
Materials
COLLADA controller -> glTF skin
Images

Looks like animations and scenes need to have the ID propagated before we can close this.

from gltf.

pjcozzi avatar pjcozzi commented on August 17, 2024

How hard do you think it is?

from gltf.

tfili avatar tfili commented on August 17, 2024

@pjcozzi These are actually going to be pretty difficult. Animation handling is complicated because the converter flattens all animations for a node into a single animation, so preserving the ID doesn't make sense if there is more than one. If there is only one animation targeting a node, then it would make sense but the logic for the more complicated case makes it difficult.

As for scenes, OpenCOLLADA seems to be missing the getOriginalID() accessor, so that why it was never done. There is a comment in there for it
//FIXME: should use this id -> visualScene->getOriginalId()

from gltf.

pjcozzi avatar pjcozzi commented on August 17, 2024

OK, let's push this post 1.0. Can you create a new wiki page in this repo for COLLADA2GLTF limitations to document this? Then we'll close this issue.

from gltf.

tfili avatar tfili commented on August 17, 2024

Created https://github.com/KhronosGroup/glTF/wiki/converter-limitations.

from gltf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.