GithubHelp home page GithubHelp logo

Comments (2)

khrynczenko avatar khrynczenko commented on July 27, 2024

Because dependencies are added in cmake with add_subdirectory, added compiler option propagate to them as well. This is unfortunate because /WX or -Werror will error not only on problems in RadioStream but also in POCO, nana etc.
Maybe we could change CMakeLists.txt so that dependencies are added with ExternalProject_Add command instead. This would allow us to set seperate options for us and them.

from radiostream.

khrynczenko avatar khrynczenko commented on July 27, 2024

So the flags were added in #74. Unfortunately the header files of the external project still gave errors because MSVC doesn't provide a way to specify inlude directories that are external (like gcc isystem <path>). Only way to do that for now is to surround external includes with

#pragma warning (push, 0)
// external includes
#pragma warning (pop)

Anyway it works and is resolved for now.

from radiostream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.