GithubHelp home page GithubHelp logo

Comments (7)

SchrodingersGat avatar SchrodingersGat commented on July 29, 2024

This is actually quite wide spread:

  • Footprints with incorrect scale - 701
  • Footprints with incorrect offset - 339
  • Footprints with incorrect rotate - 341

I can change these simply but it will break a lot of 3D models!

from kicad-footprints.

jkriege2 avatar jkriege2 commented on July 29, 2024

Do so ... but we were discussing whether these should be reworked as a hole to improve on the polarity marking on SilkS (see #78 ... maybe you can give your five cents there, so we can move forward) ... When we do that I will also change the scaling (and reexport my 3D models accordingly)

JAN

from kicad-footprints.

poeschlr avatar poeschlr commented on July 29, 2024

Wrongly scaled 3d models will not be included in the v5 repo. (Yes i know this will mean we do not have 3d models for some parts when v5 comes out.)

Changing the scaling here would only affect the v5 footprints so i think we can fix the scaling here.

from kicad-footprints.

jkriege2 avatar jkriege2 commented on July 29, 2024

Yes, but it would be good to know WHICH fooprints are affected, otherwise we will never know which models to fix!

So I would vote for doing this in batches: I.e. someone takes a repo, fixes tha scaling and at the same time fixes the 3D models, or removes them!

from kicad-footprints.

SchrodingersGat avatar SchrodingersGat commented on July 29, 2024

@jkriege2 yes I think this is a good idea. I'll close my "fix" for this :)

from kicad-footprints.

poeschlr avatar poeschlr commented on July 29, 2024

@jkriege2 the models that need fixing are simply the models present in the old kicad-library repo that do not have a counterpart in kicad-packages3d. (Sadly for a lot of them there is no easy fix because they have been designed with wings3d.)

Edit: I also think a lot of the footprints that have the wrong scaling might not even have any 3d model in either library. (They might simply stem from a time before our new ideas about correctly scaled 3d models came along.)

from kicad-footprints.

SchrodingersGat avatar SchrodingersGat commented on July 29, 2024

@poeschlr in that case, I will re-open my PR to fix this. It is better to fix the files now and add the models as we go, I think. If there are no existing incorrect models, I think that is fine.

from kicad-footprints.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.