GithubHelp home page GithubHelp logo

Comments (7)

kidpollo avatar kidpollo commented on August 16, 2024

Yo actually pose a very valid concern tho I think this is a delicate matter because I dont want the gem to depend on Rails so selecting this mechanism can be tricky.

Any preference?

from tanker.

arvida avatar arvida commented on August 16, 2024

I think we could use RACK_ENV (should be enough for most ruby webframeworks?) to check if we're running in production or not.
If we're running in production we just:

  • check if we got a Rails logging object
    • Yes: write error to rails log
    • No: create a Logger object and write error to logs/tanker.log
  • check if Hoptoad is setup
    • Yes: send a hoptoad notification with error

If we're not in production we just let the error raise.

What you think?

from tanker.

kidpollo avatar kidpollo commented on August 16, 2024

sounds interesting, I will get to this as soon as I can but pull requests are more than welcome :P

from tanker.

arvida avatar arvida commented on August 16, 2024

cool =)
we'll try and get some code done for this over the next week

from tanker.

kidpollo avatar kidpollo commented on August 16, 2024

Are you still having problems? if not can you close this issue?

from tanker.

arvida avatar arvida commented on August 16, 2024

Haven't had any time to look in to this yet... Too much work ;(
I'll close it for now.

from tanker.

kidpollo avatar kidpollo commented on August 16, 2024

yes no problem I have been busy also but I am trying to add the category feature out there really soon!

from tanker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.