Comments (7)
Yes, we have a main Map component and need the drawer as a side panel for extra operations, so we need the drawer to stay open and not get closed when you click outside ( so the user can interact with the map ), sorry I found that not providing an onClose
not an onClick
can make it stay opened but the dark overlay covers and prevents interactions with the map and i can't extend the drawer component to hide overlay hence the question about ways to try adding a className
so i can extend it.
from orbit.
Hey, I discussed this from the UX perspective with the design team, and they pointed out the same usability problem. It would be best for you to create a separate Sidebar component, feel free to reuse Drawer's code for this, since it's licensed under MIT.
from orbit.
Hi, sounds like a sensible feature to have, to improve consistency.
from orbit.
@silvenon I've a question, the current drawer doesn't close on outside click if you don't pass an onClose
prop
and control it via the shown={showDrawer}
instead, this way you can have control on what opens and closes it
but i'm trying to hide the overlay background which isn't accessible because the component has no className
prop
i've tried to extend it with cloneElement
but i failed maybe because i used it wrong.
so my question in general React components is it possible to inject a className prop to a component like this case
so i can extend it's styles?
from orbit.
So you want to have the Drawer open but without the overlay? For what purpose? And how is it connected to what you said before about onClick
and shown
props?
from orbit.
Ah, got it! Seems like a reasonable feature, we'll think about how to implement it, I suppose overlay={false}
should be fine.
from orbit.
However, no promises yet, Drawer is a component that covers part of the content, so arguably it might be a little odd to remove that overlay.
from orbit.
Related Issues (20)
- Accordion not opening HOT 2
- Datepicker and pricing/departure table HOT 1
- bug: useMediaQuery doesn't clean up after itself HOT 9
- textlink onClick when stopPropagation call two time HOT 1
- Support for React 17 HOT 4
- Accessing theme object in nextjs typescript HOT 5
- Add option to navigation bar to not hide on scroll HOT 2
- Broken SSR HOT 2
- Add "align" prop to heading component. HOT 2
- Media query hook not working on initial render. HOT 1
- docs: some Figma iframes require logging in HOT 9
- Padding right added to body when modal opened HOT 4
- Add option for select widget to have icon only
- Possibility to set timeline direction HOT 2
- available `icon list` is broken HOT 2
- ThemeProvider doesn't pass down dictionary prop properly HOT 1
- How to integrate using Rollup with orbit-components as the dependency? HOT 3
- Search shortcut (⌘ + K) doesn't work properly on FF HOT 4
- Accordion Component Broken in Latest Version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orbit.