GithubHelp home page GithubHelp logo

Comments (5)

edwardhorsford avatar edwardhorsford commented on May 26, 2024

To add, my workaround is to test for the page object - which is available when Eleventy is rendering the page, and not available when rendered under the plugin. So if it's available, I can set some default values.

from eleventy-plugin-og-image.

KiwiKilian avatar KiwiKilian commented on May 26, 2024

Thanks for reporting the issue about frontmatter. I will see if this can be fixed.

Regarding your workaround this will not work from 3.2.0 onwards. I've recently implemented the population of the page object during OG rendering in #211.

from eleventy-plugin-og-image.

edwardhorsford avatar edwardhorsford commented on May 26, 2024

@KiwiKilian Actually it was useful that the page object wasn't present - as I can have eleventy render it with some defaults if it is, and without the defaults when this plugin renders it.

I'm happy if it does get included, but I'd then request the plugin expose some data so the template can know if it's being rendered by the plugin. Perhaps ogPlugin: true or something?

from eleventy-plugin-og-image.

github-actions avatar github-actions commented on May 26, 2024

🎉 This issue has been resolved in version 3.2.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

from eleventy-plugin-og-image.

KiwiKilian avatar KiwiKilian commented on May 26, 2024

The plugin uses the internal functionality of the official Render Plugin. Which actually doesn't support front matter, so feel free to upvote in 11ty/eleventy#2712.

From my point of view there are enough other possibilities to add data and I don't think it's in the realm of this plugin to strip away the front matter. But I do understand the need to determine if the rendering is initiated by the plugin. Therefore I've added a eleventyPluginOgImage data key with some options for such detection.

from eleventy-plugin-og-image.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.