Comments (2)
- I find odd that the libkiwix version is defined in the Brewfile. libkiwix is our top dependency and exposing it solely in a URL in the Brewfile feels hackish.
@rgaudin What would be an better altenative approach?
* This PR doesn't update the CI and CD workflows which now relies on this mechanism. We thus end up with a `LIBKIWIX-VERSION` environ on those files that makes it look like it controls the version used while it doesn't anymore.
@BPerlakiH Why?
* README says that the Brewfile will install **latest** CoreKiwix. That's not true. It will install the version specified in the brewfile. We have a URL for the latest version but we're not using it (on purpose) so this sentence is misleading.
Dependencies version should be explicit anyway. Readme should be fixed.
* `DEVELOPMENT_TEAM` is not a secret value but it's part of the several values associated with signing. In all repos we need them, we store it as a secret for convenience: when updating signing params, everything's in the same place. Given it doesn't change when certificates are renewed, we should remove it from the secrets… but you need to remove it from the places that are looking for it (CI, CD).
I prefer the secret for convenience, but if this approach is proven to be combersome, then lets hardcode it everywhere. In any case, this has to be fixed.
@BPerlakiH Please treat ticket in priority.
from apple.
I've addressed these issues here: #610
The Development Team value. Yes, I think that can be removed from secrets, I do not think it is a priority atm.
The team id value contained in the project file is only a default one, and can be overwritten both in the building, and later in the code signing process. For these reasons, I think it can be treated separately.
The code signing part is really a separate step. It is so much separated, that in theory even a different team id can be used to sign the final app. I think, at the very end of the review process Apple even re-signs all the apps once more, before they make it to the App Store in their final form.
Since we are about to update the code signing / releasing part of our process (to fastlane + match), I would like to leave this part for later.
I will keep in mind that we should ideally have a single source of truth for the value of the team id, if that's possible.
from apple.
Related Issues (20)
- Change url scheme from "kiwix://" to "zim://"
- Stop displaying a dialog box, if content of a framset or oframe is missing HOT 1
- Video does not stop in tab is close HOT 2
- Audio not playing on any videos in MacOS 14.5 with KhanAcademy ZIM on Kiwix 3.3.0, the weblink doesn't work either in Safari but works in Firefox? HOT 7
- Can't read Zim files HOT 5
- Integrate Codecov to the CI
- macOS: Side tab should update after unlinking a ZIM file
- Export of a PDF fails HOT 3
- ZIM is not vertically alligned properly HOT 1
- Losing capacity to focus in a ZIM HOT 1
- Bookmarking a PDF fails
- Under certain condition opening ZIM (homepage) gives a black screen HOT 5
- Navigation history should be empty at ZIM opening time HOT 4
- Improve bookmark data for PDF files HOT 2
- Bookmark data without image and snippet
- Fix UI warning of tab reconfiguration, plus improve the look of icons
- Use libkiwix xcframeworks 13.1.0-4
- Opening corruped file leads to crash HOT 2
- Content default positioning is not always correct
- iOS: Unable to open file (which works in Kiwix elsewhere) HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apple.