GithubHelp home page GithubHelp logo

Polish Xcode integration about apple HOT 2 CLOSED

kelson42 avatar kelson42 commented on July 1, 2024
Polish Xcode integration

from apple.

Comments (2)

kelson42 avatar kelson42 commented on July 1, 2024
  • I find odd that the libkiwix version is defined in the Brewfile. libkiwix is our top dependency and exposing it solely in a URL in the Brewfile feels hackish.

@rgaudin What would be an better altenative approach?

* This PR doesn't update the CI and CD workflows which now relies on this mechanism. We thus end up with a `LIBKIWIX-VERSION` environ on those files that makes it look like it controls the version used while it doesn't anymore.

@BPerlakiH Why?

* README says that the Brewfile will install **latest** CoreKiwix. That's not true. It will install the version specified in the brewfile. We have a URL for the latest version but we're not using it (on purpose) so this sentence is misleading.

Dependencies version should be explicit anyway. Readme should be fixed.

* `DEVELOPMENT_TEAM` is not a secret value but it's part of the several values associated with signing. In all repos we need them, we store it as a secret for convenience: when updating signing params, everything's in the same place. Given it doesn't change when certificates are renewed, we should remove it from the secrets… but you need to remove it from the places that are looking for it (CI, CD).

I prefer the secret for convenience, but if this approach is proven to be combersome, then lets hardcode it everywhere. In any case, this has to be fixed.

@BPerlakiH Please treat ticket in priority.

from apple.

BPerlakiH avatar BPerlakiH commented on July 1, 2024

I've addressed these issues here: #610

The Development Team value. Yes, I think that can be removed from secrets, I do not think it is a priority atm.

The team id value contained in the project file is only a default one, and can be overwritten both in the building, and later in the code signing process. For these reasons, I think it can be treated separately.

The code signing part is really a separate step. It is so much separated, that in theory even a different team id can be used to sign the final app. I think, at the very end of the review process Apple even re-signs all the apps once more, before they make it to the App Store in their final form.

Since we are about to update the code signing / releasing part of our process (to fastlane + match), I would like to leave this part for later.

I will keep in mind that we should ideally have a single source of truth for the value of the team id, if that's possible.

from apple.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.