ZIM metadata „illustration“ is not read properly about apple

[rgaudin]

The code change itself won't change the image data already written into the local DB, before the fix.

OK that explains it. Are we OK with this? If yes then this ticket should be closed

[kelson42]

Not sure how this is done, but there is a primitive in libkiwix which shiukd be used:
https://libkiwix.readthedocs.io/en/latest/api/classkiwix_1_1Book_1_1Illustration.html?highlight=Illustration

I suspect that because the logo of the ZIM is accessed directly and because we have changed in the path the URL, then something is wrong. Please read https://wiki.openzim.org/wiki/Metadata

[rgaudin]

The reader is using its url property

book->getIllustrations().at(0)->url

Documentation is of no help here but a quick glimpse at the code have me believe that url is only set when read from XML or from OPDS so in apple reader's case, only if downloaded from the catalog. I could confirm this with a test.

@BPerlakiH, we should use getData() indeed.
A quick hack could be returning a base64 image/png url as this is used as an URL 😝

[kelson42]

Makes sense, metadata should be retrieved from online catalogue AFAP, but if no entry there, ALL metadata (illustration included) should come from the ZIM file.

[kelson42]

Still not working:

[kelson42]

After iOS update to version 18... it works!

I'm a bit puzzled.

[rgaudin]

Solar Powered and Quartiers chinois still use category image in this screenshot…

[rgaudin]

Given you use this device to test the app, I'm not sure it's a wise choice to be on a beta system… but there's no downgrade possible so it's too late now 😀

[kelson42]

Given you use this device to test the app, I'm not sure it's a wise choice to be on a beta system… but there's no downgrade possible so it's too late now 😀

Yes, but see it the other way: we prefer to detect problems with iOS18 earlier, better than waiting the system is live.

@rgaudin How does you iOS device behaves regarding this very specific issue? Is rhat fixed for you?

[rgaudin]

I figured, but you're the only tester we have! Hope it works well on current stable!

[rgaudin]

Current Testflight for macOS (published 3days ago) still exhibits the bug

[kelson42]

@rgaudin Thx, I wonder if there is not a cache somewhere which would make the test of the patch complicated!?

[BPerlakiH]

Current Testflight for macOS (published 3days ago) still exhibits the bug

@rgaudin can you tell me which icon is wrong ?

[rgaudin]

The one you see top left. that's not a zim icon but the other category icon in the app.

Only zim added via catalog shows their icons

[BPerlakiH]

I think I have the same file, on the current main branch it looks good after adding it.

I have the same result using the TestFlight version.
The code change itself won't change the image data already written into the local DB, before the fix.
Can you try to unlink the file, and add it again?

[BPerlakiH]

I think the same happened for @kelson42 as well, after the iOS update, the files must have been re-added to the local DB, and from then on they were fixed.

[kelson42]

Moving to 3.5.0