Comments (7)
Fix 1 is not easy in good conditions in warc2zim. It would means removing the trailing /
in all entries which have one (quite possible) but it means we have a risk of conflict, probably rare but mostly impossible to solve. It is perfectly legit for a website to have two different resources at two different URLs differing only by a trailing /
(e.g. www.example.com/myresource
and www.example.com/myresource/
).
Since ZIM entries are just a "string", mostly mapped to a URL, and URLs ending with a slash are legit, I don't get why we would impose more constraints that necessary on ZIM entries.
from apple.
Plus removing a trailing slash in the path of a ZIM entry corresponding to an HTML document means that all relative URLs in the document have to be adapted because we are not anymore in a "folder" but an a "file".
from apple.
Fix 1 if possible in good conditions, not because this is wrong, but because this can be a source of trouble without bringing clear advantage.
AND
Fix 2 because Kiwix should work properly anyway and macOS15 will be released within a few month (so we can just bump the version of Swift... but maybe better in 3.5.0.
from apple.
@BPerlakiH The we have the point 2 left!
from apple.
Why not point 3 for 3.4, and point 2 for 3.5? (I mean, the code of point 3 seems a bit custom but rather plain simple to write)
from apple.
Why not point 3 for 3.4, and point 2 for 3.5? (I mean, the code of point 3 seems a bit custom but rather plain simple to write)
😇
from apple.
Why not point 3 for 3.4, and point 2 for 3.5? (I mean, the code of point 3 seems a bit custom but rather plain simple to write)
😇
Sounds a bit like a hack to me, which will be later rolled back. this is why I prefer #2 straight.
from apple.
Related Issues (20)
- Opening corruped file leads to crash HOT 16
- Content default positioning is not always correct
- iOS: Unable to open file (which works in Kiwix elsewhere) HOT 13
- DMG has not been published HOT 1
- NIghly build CD has failed
- No search result when the key word more than 1 byte with Chinese zim files HOT 6
- Double-clicking on a ZIM in finder opens a new Kiwix window HOT 4
- Crash 3.4.0 - Kiwix: OPDSParser.parse(data:) +36 HOT 2
- Crash 3.4.0 - Kiwix: u_setDataDirectory_73 + 48
- Crash 3.4.0 - libxml2.2.dylib: xmlMallocZero +48 HOT 4
- Crash 3.4.0 - Levenshtein.calculate(_:_:) +72
- Crash 3.4.0 - Kiwix: u_setDataDirectory_73 + 112 HOT 1
- Crash 3.4.0 - SwiftUI: specialized _ArrayBuffer._consumeAndCreateNew(bufferIsUnique:minimumCapacity...
- Crash 3.4.0 -[UIPopoverPresentationController presentationTransactionWillBegin] + 2672
- Add support for multiple reader windows HOT 1
- Moving Zim Files from Download folder to another Drive/Folder HOT 3
- Library loading is blocking the main thread HOT 1
- Resolve Swift Package Dependencies Automatically
- Remove BackPorts dependency
- No book found line for "lowtech"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apple.