Comments (26)
See this StackOverflow Question: http://stackoverflow.com/questions/146134/how-to-remove-illegal-characters-from-path-and-filenames
from brake.
Would this do?
System.IO.Path.GetInvalidFileNameChars().
string filename = tVS.Nodes[r].Text;
foreach(char c in System.IO.Path.GetInvalidFileNameChars()) {
filename = filename.Replace(c, '_');
}
from brake.
Why don't you give it a go and see if it works - if it does make a pull request. :)
from brake.
Sure :P
I was just asking on your opinion :)
One more thing, will it interfere with the rest of the script (when it comes to zipping it up)?
from brake.
I don't know the codebase, I work on the Mac version. Sorry!
from brake.
No problem ;)
from brake.
This is really weird...
When attempting to manually extract it with WinRAR, it automatically renames the file.
But when Brake attempts to extract it, it crashes...
I'm gonna need help for this issue, since I've tried at least 5 different ways to rename the file, and none of them worked... (or I'm just really dumb, since I'm a noob)
from brake.
Post a couple of the implementations you tried for ttwj.
from brake.
Like I said, I might have done something wrong.
But now I'm going to sleep, and I'll post it tomorrow.
from brake.
So anything regex related didn't work on it, and if statement didn't work (if e.FileName.contains ":").
foreach didn't work as well. (but like I said, maybe ttwj can figure something out)
from brake.
Is the illegal characters issue with the IPA or the files in it
On 19 Oct 2013 23:57, "DblD" [email protected] wrote:
So anything regex related didn't work on it, and if statement didn't work
(if e.FileName.contains ":").
foreach didn't work as well. (but like I said, maybe ttwj can figure
something out)—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26652529
.
from brake.
IPA files never have illegal chars in them on Windows.
But .app folder can have illegal chars.
And that .app folder is the issue.
If it could be renamed, it would solve the problem.
from brake.
Yea I don't think we can fix that issue, screw windows.
On 20 Oct 2013 00:03, "DblD" [email protected] wrote:
IPA files never have illegal chars in them on Windows.
But .app folder can have illegal chars.
And that .app folder is the issue.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26652682
.
from brake.
Can we in that case copy the whole ipa over, and run Clutch thru ssh (like you would thru mobile terminal), and take the whole cracked ipa back?
from brake.
um that's a stupid idea but ok
On 20 Oct 2013 00:09, "DblD" [email protected] wrote:
Can we in that case copy the whole ipa over, and run Clutch thru ssh, and
take the whole cracked ipa back?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26652843
.
from brake.
Well, we could always say "ERROR: Could not be cracked, brake doesn't have enough swag on windows!"
from brake.
good idea
On 20 Oct 2013 00:11, "DblD" [email protected] wrote:
Well, we could always say "ERROR: Could not be cracked, brake doesn't have
enough swag on windows!"—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26652902
.
from brake.
This issue can be fixed, it'll just take some work by the windows team, Brake & Clutch need to be coded to a decent quality. If need be I can set environment and learn the basics of C# and windows quick. But this isn't a hard bug to quash.
from brake.
The only way this could be fixed is that either we magically rename the file somehow, or just simply send the whole ipa to the phone, install it, and run Clutch, and bring back the cracked ipa.
from brake.
it's an issue with the zip library, we're not using the latest version so
maybe they fixed it idk
On 20 Oct 2013 00:35, "DblD" [email protected] wrote:
The only way this could be fixed is that either we magically rename the
file somehow, or just simply send the whole ipa to the phone, install it,
and run Clutch, and bring back the cracked ipa.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26653441
.
from brake.
Why don't we use the latest version then?
But I doubt they fixed it tbh...
from brake.
I used a patched version that works properly on Mac, maybe they removed the
protection for such illegal characters
On 20 Oct 2013 00:43, "DblD" [email protected] wrote:
Why don't we use the latest version then?
But I doubt they fixed it tbh...—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26653612
.
from brake.
It cannot be that difficult to rename a file in C#. Surely.
from brake.
The problem is that that file is inside the zip.
7-zip for example doesn't extract it at all due to it having an illegal character.
Only WinRAR did it (and that was when I tried manually).
Also I tried the newest Ionic.Zip.dll and Brake wouldn't run at all for some reason...
from brake.
Maybe some of these might help?
http://stackoverflow.com/questions/6413224/dotnetzip-rename-file-entry-in-zip-file-while-compressing
http://stackoverflow.com/questions/2405758/dotnetzip-how-to-extract-files-but-ignoring-the-path-in-the-zipfile
http://dotnetzip.codeplex.com/wikipage?title=CS-Examples
I'll check on them later, I'm busy with other stuff now.
from brake.
http://dotnetzip.codeplex.com/discussions/247531
This might work as well, I'll check this out too.
from brake.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brake.