GithubHelp home page GithubHelp logo

Comments (26)

NinjaLikesCheez avatar NinjaLikesCheez commented on August 25, 2024

See this StackOverflow Question: http://stackoverflow.com/questions/146134/how-to-remove-illegal-characters-from-path-and-filenames

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

Would this do?

System.IO.Path.GetInvalidFileNameChars().

string filename = tVS.Nodes[r].Text;

foreach(char c in System.IO.Path.GetInvalidFileNameChars()) {
filename = filename.Replace(c, '_');
}

from brake.

NinjaLikesCheez avatar NinjaLikesCheez commented on August 25, 2024

Why don't you give it a go and see if it works - if it does make a pull request. :)

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

Sure :P
I was just asking on your opinion :)
One more thing, will it interfere with the rest of the script (when it comes to zipping it up)?

from brake.

NinjaLikesCheez avatar NinjaLikesCheez commented on August 25, 2024

I don't know the codebase, I work on the Mac version. Sorry!

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

No problem ;)

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

This is really weird...
When attempting to manually extract it with WinRAR, it automatically renames the file.
But when Brake attempts to extract it, it crashes...

I'm gonna need help for this issue, since I've tried at least 5 different ways to rename the file, and none of them worked... (or I'm just really dumb, since I'm a noob)

from brake.

NinjaLikesCheez avatar NinjaLikesCheez commented on August 25, 2024

Post a couple of the implementations you tried for ttwj.

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

Like I said, I might have done something wrong.
But now I'm going to sleep, and I'll post it tomorrow.

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

So anything regex related didn't work on it, and if statement didn't work (if e.FileName.contains ":").
foreach didn't work as well. (but like I said, maybe ttwj can figure something out)

from brake.

ttwj avatar ttwj commented on August 25, 2024

Is the illegal characters issue with the IPA or the files in it
On 19 Oct 2013 23:57, "DblD" [email protected] wrote:

So anything regex related didn't work on it, and if statement didn't work
(if e.FileName.contains ":").
foreach didn't work as well. (but like I said, maybe ttwj can figure
something out)


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26652529
.

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

IPA files never have illegal chars in them on Windows.
But .app folder can have illegal chars.
And that .app folder is the issue.
If it could be renamed, it would solve the problem.

from brake.

ttwj avatar ttwj commented on August 25, 2024

Yea I don't think we can fix that issue, screw windows.
On 20 Oct 2013 00:03, "DblD" [email protected] wrote:

IPA files never have illegal chars in them on Windows.
But .app folder can have illegal chars.
And that .app folder is the issue.


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26652682
.

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

Can we in that case copy the whole ipa over, and run Clutch thru ssh (like you would thru mobile terminal), and take the whole cracked ipa back?

from brake.

ttwj avatar ttwj commented on August 25, 2024

um that's a stupid idea but ok
On 20 Oct 2013 00:09, "DblD" [email protected] wrote:

Can we in that case copy the whole ipa over, and run Clutch thru ssh, and
take the whole cracked ipa back?


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26652843
.

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

Well, we could always say "ERROR: Could not be cracked, brake doesn't have enough swag on windows!"

from brake.

ttwj avatar ttwj commented on August 25, 2024

good idea
On 20 Oct 2013 00:11, "DblD" [email protected] wrote:

Well, we could always say "ERROR: Could not be cracked, brake doesn't have
enough swag on windows!"


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26652902
.

from brake.

NinjaLikesCheez avatar NinjaLikesCheez commented on August 25, 2024

This issue can be fixed, it'll just take some work by the windows team, Brake & Clutch need to be coded to a decent quality. If need be I can set environment and learn the basics of C# and windows quick. But this isn't a hard bug to quash.

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

The only way this could be fixed is that either we magically rename the file somehow, or just simply send the whole ipa to the phone, install it, and run Clutch, and bring back the cracked ipa.

from brake.

ttwj avatar ttwj commented on August 25, 2024

it's an issue with the zip library, we're not using the latest version so
maybe they fixed it idk
On 20 Oct 2013 00:35, "DblD" [email protected] wrote:

The only way this could be fixed is that either we magically rename the
file somehow, or just simply send the whole ipa to the phone, install it,
and run Clutch, and bring back the cracked ipa.


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26653441
.

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

Why don't we use the latest version then?
But I doubt they fixed it tbh...

from brake.

ttwj avatar ttwj commented on August 25, 2024

I used a patched version that works properly on Mac, maybe they removed the
protection for such illegal characters
On 20 Oct 2013 00:43, "DblD" [email protected] wrote:

Why don't we use the latest version then?
But I doubt they fixed it tbh...


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-26653612
.

from brake.

NinjaLikesCheez avatar NinjaLikesCheez commented on August 25, 2024

It cannot be that difficult to rename a file in C#. Surely.

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

The problem is that that file is inside the zip.
7-zip for example doesn't extract it at all due to it having an illegal character.
Only WinRAR did it (and that was when I tried manually).

Also I tried the newest Ionic.Zip.dll and Brake wouldn't run at all for some reason...

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

Maybe some of these might help?
http://stackoverflow.com/questions/6413224/dotnetzip-rename-file-entry-in-zip-file-while-compressing
http://stackoverflow.com/questions/2405758/dotnetzip-how-to-extract-files-but-ignoring-the-path-in-the-zipfile
http://dotnetzip.codeplex.com/wikipage?title=CS-Examples

I'll check on them later, I'm busy with other stuff now.

from brake.

DoubleDoughnut avatar DoubleDoughnut commented on August 25, 2024

http://dotnetzip.codeplex.com/discussions/247531

This might work as well, I'll check this out too.

from brake.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.