Comments (6)
@cjcheshire Thanks for using this module :) When I created it, I used another module that creates a basic iOS/Android (and I think windows) RN package. I didn't edit the android stuff at all, and don't remember if I even tested it or not.
I'll eventually get around to removing the native android code. Thank you for finding this! It'll be a few weeks probably (new baby in the house) before I can find the time to go through my code and fully make sure it's working properly again.
from react-native-rate.
Totally understand that. Mines one tomorrow. Many congratulations and thanks again for the library :)
from react-native-rate.
@KjellConnelly So is this fixed now?
from react-native-rate.
Idk. I looked at your reference and saw I merged a pull request. But I believe the android code is still all there. Never got around to deleting it since it wasn’t an issue on my current apps.
from react-native-rate.
Ok, so if i understand it correctly: It is eventually not fixed, but the code is not used by default on Android anyways?
Thanks for the quick response. I would like to use your lib and just want to understand, if it is working on both platforms :) Thank you for sharing it.
from react-native-rate.
@buechner The native Android module is never used as it's just boilerplate. So when you run the app on Android, it should use only the javascript code. When you run it on iOS, most of the code runs through javascript, though there is one feature which requires native objective-c code.
So it should work for both. If you use this module, it is possible that you will get the same error as cjcheshire did when you run on Android. I don't get that error, but it's possible that it's because I'm using RN from a year and a half ago along with all the build tools. If you do get that error, try removing the Android stuff and it might be gone.
I'm not very fluent with Android or building these RN modules. Kind of just learn as I build. Which is why I'm not 100% sure on what needs to be removed. Possibly just deleting the entire Android folder would be enough. I'm not sure though as my current apps have a lot of other bugs to iron out on Android first before the apps will even run (as I've been focusing on the iOS side of things only for the past several weeks)
from react-native-rate.
Related Issues (20)
- Rating module not always showing and App Store showing "Cannot connect to App Store" on redirect HOT 1
- preferInApp in Android makes the modal unreliable HOT 11
- Rating not submitting, keeps popping up HOT 5
- Can't get correct callback value when review modal is already shown
- fix: duplicate definitions for React
- Question: Android packge name or ApplicationID HOT 1
- Support new React Native new architecture (TurboModules/Fabric) HOT 3
- Not work when building HOT 3
- Android failing to build HOT 2
- Android build is failed with checkDebugDuplicateClasses error. HOT 6
- Error using library Could not invoke RNRate.rate - Android HOT 3
- React Native Rate prompt is navigating to App Store IOS HOT 2
- Redirecting to Appstore HOT 3
- iOS 15 press Not now freezzs the app HOT 1
- Where is the changelog and version control of this package? HOT 1
- Move from jcenter to maven HOT 2
- Unused `options` parameter in Android implementation HOT 1
- Drop callback interface in favour of promises HOT 1
- Declaration of 'RCTConvert' must be imported from module 'React.RCTConvert' before it is required HOT 2
- Remove jcenter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-rate.