Comments (5)
I've got a fix pending on the SDL side. Still thinking about what I want to do here. Falling back to the no-icon form is likely the right choice, though I am also thinking about what should be done in both functions if the title is NULL
- perhaps a signal to remove the window from the advertised window list.
from toaruos.
Despite a null check later in the function, yutani_window_advertise_icon
is not intended to accept NULL
for the icon; clients should use yutani_window_advertise
instead. The bug lies in the SDL backend: TOARU_SetCaption
should be choosing yutani_window_advertise
if icon
is NULL
. I would transfer this issue to the SDL fork, but I don't seem to have issues enabled for that repository.
from toaruos.
In that case, this if is redundant:
Line 816 in abe66fb
from toaruos.
Yeah. Maybe it should support a NULL
icon... and it should probably also support a NULL
name, which it fails to do in the same way... :\
from toaruos.
Will you fix it? In my opinion, the fix is quite obvious.
from toaruos.
Related Issues (20)
- Can we fix the clock in bochs? HOT 1
- [docker build fails] /bin/sh: 1: kuroko: Permission denied HOT 1
- ToaruOS 2.2 Roadmap
- Is it possible to port FFmpeg to toaruos? HOT 4
- will it work on real hardware? HOT 2
- Some issues HOT 3
- Implement locking for `stdio` streams
- Kernel panic in `mmu_unmap_user` in threaded app HOT 8
- Webbrowser? Firefox? HOT 5
- window minimization? HOT 3
- Vulnerability in signals HOT 4
- Very slow graphics HOT 3
- Calling fswait can cause the kernel to crash. HOT 2
- Restore Netsurf port HOT 2
- SoundHw in Qemu no longer works HOT 2
- How to transfer files using qemu startup HOT 3
- init: double fd 1 and no fd 2 HOT 2
- Evaluate Profile-Guided Optimization (PGO)
- docker 400 error HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from toaruos.