GithubHelp home page GithubHelp logo

Comments (5)

klemens-morgenstern avatar klemens-morgenstern commented on June 30, 2024

Different editors on windows & linux. I looked out to use spaces instead of tabs, but didn't even notice that. Just out of curiousity: where does that become a problem?

from boost-process.

ChrisKitching avatar ChrisKitching commented on June 30, 2024

Some tools dislike mixed line endings in the same files.

People using editors which normalise newlines on load (which are annoyingly plentiful) will end up causing spurious git changes (as all those lines count as edited).

Bad things can happen if other people haven't carefully read the git manual page about autocrlf (which, incidentally, is how you use different editors across windows/Linux and avoid ending up in this situation): https://help.github.com/articles/dealing-with-line-endings/

In short: developers have to be aware that this is the situation, and take action to avoid cluttering git history with useless changes as a result.

from boost-process.

klemens-morgenstern avatar klemens-morgenstern commented on June 30, 2024

Makes, sense I didn't notice.

from boost-process.

ChrisKitching avatar ChrisKitching commented on June 30, 2024

Incidentally, your commit only changed lines that consist only of a newline. Now files that used to be pure crlf are a mixture of both, which is in many ways even worse, since the default "save" behaviour of many editors is to set all line endings to the same character.

The amount of lines you'd end up touching to convert everything to \n turns out to be enormous: running dos2unix over the whole repo ends up with a diffstat of 58 files changed, 6324 insertions(+), 6324 deletions(-). Clobbering that amount of git blame is arguably not a good idea.

I guess the thing to do might be to make all files use one or the other and consistently use only one going forward?

Another alternative would be to history-rewrite the entire repository, although that's a terrible idea for other reasons.

Certainly, you might want to force-push off that big commit you did...

from boost-process.

klemens-morgenstern avatar klemens-morgenstern commented on June 30, 2024

I'll try to figure something out, git is killing me with that on windows.
There is however no style requirement in boost, so that'll be alright for now I guess.

from boost-process.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.