GithubHelp home page GithubHelp logo

Comments (3)

ArturT avatar ArturT commented on June 18, 2024

Hi @vipulnsward

Can you ensure you have in Gemfile

group :test do
  gem 'vcr'
  gem 'webmock', require: false # this must be set to false
end

in spec helper or rails helper you must ensure requests to Knapsack Pro API are allowed.

require 'vcr'
VCR.configure do |config|
  config.hook_into :webmock
  config.ignore_hosts('localhost', '127.0.0.1', '0.0.0.0', 'api.knapsackpro.com')
end

# add below when you hook into webmock
require 'webmock/rspec'
WebMock.disable_net_connect!(allow_localhost: true, allow: ['api.knapsackpro.com'])

This is based on tips in https://docs.knapsackpro.com/knapsack_pro-ruby/guide/

Do you run tests on CI? Are they failing on CI or do you test this locally?

Can you paste the exact error with backtrace returned by RSpec when running knapsack_pro command?

Can you paste your test code, how do you use VCR. How the path to the cassette looks like.

Do you use parallel_tests gem at the same time?

Do you reconfigure VCR somehow during runtime of the tests?

I don't recall any similar issue to yours so I'm wondering if this is something specific to your project and how you setup VCR.

from knapsack_pro-ruby.

vipulnsward avatar vipulnsward commented on June 18, 2024

Update:

We had 2 uses of VCR.configuration.ignore_request { true } for some variable request specs.
Commenting them out seems to make the CI be stable again.

Will need to figure out why this is though, since we do need them for some valid spec scenarios and it seems to work fine if run without knapsack/threaded mode.

Can close this issue, if you'd like meanwhile.

from knapsack_pro-ruby.

ArturT avatar ArturT commented on June 18, 2024

It looks like you have to adjust your block VCR.configuration.ignore_request { true } to return false when the request is going to Knapsack Pro API (You should allow a request for api.knapsackpro.com) and otherwise, return true to keep your current behavior.
https://relishapp.com/vcr/vcr/v/2-2-5/docs/configuration/ignore-request

If you see any exception or backtrace error please share. You can also send a message to support email https://knapsackpro.com/contact if this contains private data.

For now, I would say it's rather not related to "mutex/thread context issue" because you run knapsack_pro command per CI node in the isolated machine (i.e. docker container in Buildkite I guess). So just 1 test is executed at a time inside of knapsack_pro process using RSpec.

from knapsack_pro-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.