Comments (4)
Seems to work, thanks!
from knapsack_pro-ruby.
At this moment knapsack_pro has no hook like that and probably it might be a bit hard to provide after queue end hook
because I know when queue is ended when I got no test files from Knapsack Pro API. It means I won't run more tests to hook into after(:suite)
to set the knapsack pro after queue end hook
.
Maybe I could find other workaround but I need to think more about it.
I looked at the documentation https://percy.io/docs/clients/ruby/capybara-rails
and probably this may work.
# spec_helper.rb or rails_helper.rb
unless ENV['KNAPSACK_PRO_RSPEC_PERCY_HOOKS_LOADED']
ENV['KNAPSACK_PRO_RSPEC_PERCY_HOOKS_LOADED'] = 'true'
Percy::Capybara.initialize_build
at_exit { Percy::Capybara.finalize_build }
end
Could you check that?
from knapsack_pro-ruby.
Great! I've updated FAQ https://github.com/KnapsackPro/knapsack_pro-ruby#how-to-set-beforesuite-and-aftersuite-rspec-hooks-in-queue-mode-percyio-example
from knapsack_pro-ruby.
I think the example can be even more simplified:
# spec_helper.rb or rails_helper.rb
# executes before Queue Mode starts work
Percy::Capybara.initialize_build
# executes after Queue Mode finishes work
at_exit { Percy::Capybara.finalize_build }
I tested that and this should be executed only once at the beginning and at the end.
from knapsack_pro-ruby.
Related Issues (20)
- Lots of failures with rolify gem after 4.1 -> 5.0 bump HOT 12
- Docs need to specify ENV var to detect CI provider HOT 1
- Fail gracefully when there's no git HOT 8
- Running `git fetch --shallow-since` to fetch commit author log causes hang on Buildkite runners HOT 12
- rspec-core conflict HOT 4
- Running queue mode locally for troubleshooting with a small subset of tests, but with multiple batches HOT 6
- Does `rake knapsack_pro:rspec_test_example_detector` need to run if there aren't any slow specs? HOT 2
- Slow test analysis runs even when there's no slow tests HOT 2
- Disable example_status_persistence_file_path HOT 3
- Create a replication command on failed node HOT 2
- Incompatibility with rspec --options on 6.0+ HOT 11
- NoMethodError: undefined method `rspec_is_quitting' HOT 2
- NoMethodError: undefined method `rspec_is_quitting' for RSpec::Core::World HOT 1
- After upgrading to minitest 5.22.0 I get error status even if all test pass HOT 8
- NoMethodError: undefined method `keys' for nil HOT 20
- Failing RSpec tests on ~>7.0.0 HOT 9
- DataDog dropping RSpec tests with the knapsack_pro 7.x gem in Queue Mode HOT 1
- Knapsack v7 ignores run options defined in spec_helpers. HOT 3
- Ruby 3.3 support? HOT 4
- Simplecov doesnt work with Knapsack Pro 7.4 and minitest HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knapsack_pro-ruby.