Comments (9)
@adrcunha Would you consider our current testing sufficient to close out this issue? Between the checks built in to Prow and @mattmoor 's Sockpuppet bot, I feel pretty good about our coverage.
from docs.
TL;DR: No.
Currently there are no unit tests. At all:
Line 28 in df75e7e
Also there are no build tests, and the E2E tests are just checking that Knative Serving starts (which is not affected by any changes in this repo).
Currently there's nothing preventing doc
from getting broken code merged (e.g., samples), or even bad markdown files (I dunno how often Matt's bot lints/validates/fixes them). Although some of the infrastructure required is in place (e.g., knative/test-infra#192), it's not active yet.
from docs.
Thanks for the background. Is there any kind of timeline for this work yet?
from docs.
Not that I am aware of. But we can definitely bring this up in the next documentation or productivity meeting.
from docs.
That would be great! I'll add you to the agenda for the documentation working group on 1/8.
from docs.
Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale
.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close
.
Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.
/lifecycle stale
from docs.
Stale issues rot after 30 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten
.
Rotten issues close after an additional 30 days of inactivity.
If this issue is safe to close now please do so by adding the comment /close
.
Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.
/lifecycle rotten
from docs.
It seems that the amount of testing we currently have is enough.
/close
from docs.
@adrcunha: Closing this issue.
In response to this:
It seems that the amount of testing we currently have is enough.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from docs.
Related Issues (20)
- Sample App: BookReview Service: Broker implementation
- Sample App: ML Service - Knative Sequence
- Sample App: BookReview Service: Implement the microservice v2
- Sample App: Notification Service: Adding the tutorial on how to create the slack workspace HOT 3
- Sample App: Add the documentation for how to use func invoke
- Add the best use case example for different Knative Features HOT 3
- Sample App: Documentation Cleanup
- Sample App: Use Secret instead of plaintext for slack sink webhook HOT 2
- Sample App: Code clean up HOT 2
- Provide more example usage for channel-configuration in the doc HOT 1
- We should add our LinkedIn page link to follow us section of our website HOT 9
- Improve Site Performance with Lazy Loading and WEBP Images HOT 13
- Add Social Share Buttons to Blog Page HOT 7
- KnativeServing CR overriding the queue-proxy registry which didn't work
- Add new CNCF case study to Knative website HOT 5
- Improving the consistency in the case study logos HOT 1
- Minor Grammatical Errors throughout the Documentation HOT 2
- Add Toggle Button for Light/Dark Mode HOT 3
- Bug: Inconsistent display of Marque in Windows HOT 10
- Convert PNG Logos in Case Study Section to Next-Gen Formats HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docs.