GithubHelp home page GithubHelp logo

Create unit tests about docs HOT 9 CLOSED

knative avatar knative commented on July 23, 2024
Create unit tests

from docs.

Comments (9)

samodell avatar samodell commented on July 23, 2024

@adrcunha Would you consider our current testing sufficient to close out this issue? Between the checks built in to Prow and @mattmoor 's Sockpuppet bot, I feel pretty good about our coverage.

from docs.

adrcunha avatar adrcunha commented on July 23, 2024

TL;DR: No.

Currently there are no unit tests. At all:

header "TODO(#66): Write unit tests"

Also there are no build tests, and the E2E tests are just checking that Knative Serving starts (which is not affected by any changes in this repo).

Currently there's nothing preventing doc from getting broken code merged (e.g., samples), or even bad markdown files (I dunno how often Matt's bot lints/validates/fixes them). Although some of the infrastructure required is in place (e.g., knative/test-infra#192), it's not active yet.

from docs.

samodell avatar samodell commented on July 23, 2024

Thanks for the background. Is there any kind of timeline for this work yet?

from docs.

adrcunha avatar adrcunha commented on July 23, 2024

Not that I am aware of. But we can definitely bring this up in the next documentation or productivity meeting.

from docs.

samodell avatar samodell commented on July 23, 2024

That would be great! I'll add you to the agenda for the documentation working group on 1/8.

from docs.

knative-housekeeping-robot avatar knative-housekeeping-robot commented on July 23, 2024

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

from docs.

knative-housekeeping-robot avatar knative-housekeeping-robot commented on July 23, 2024

Stale issues rot after 30 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.
Rotten issues close after an additional 30 days of inactivity.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle rotten

from docs.

adrcunha avatar adrcunha commented on July 23, 2024

It seems that the amount of testing we currently have is enough.

/close

from docs.

knative-prow-robot avatar knative-prow-robot commented on July 23, 2024

@adrcunha: Closing this issue.

In response to this:

It seems that the amount of testing we currently have is enough.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.