GithubHelp home page GithubHelp logo

Comments (11)

ReToCode avatar ReToCode commented on June 24, 2024

You probably want https://knative.dev/docs/serving/configuration/feature-flags/#kubernetes-node-selector?

from serving.

springCozyRock avatar springCozyRock commented on June 24, 2024

hi @ReToCode , thx a lot. I was actually refering to this url. Is there anything else I have to do?

from serving.

ReToCode avatar ReToCode commented on June 24, 2024

No that should work. Are you sure you set kubernetes.podspec-nodeselector at the correct place (not in the _example section)?

from serving.

springCozyRock avatar springCozyRock commented on June 24, 2024

I didnot know I should edit Config Map before. Pretty stupid. Let me try and I willclose the issue. Thanks a lot!

    # Indicates whether Kubernetes nodeSelector support is enabled
    #
    # WARNING: Cannot safely be disabled once enabled.
    # See: https://knative.dev/docs/serving/feature-flags/#kubernetes-node-selector
    kubernetes.podspec-nodeselector: "disabled"

from serving.

springCozyRock avatar springCozyRock commented on June 24, 2024

I failed to edit this.

beatles@kmaster:~$ sudo kubectl edit configmap config-features -n knative-serving
error: configmaps "config-features" could not be patched: admission webhook "config.webhook.serving.knative.dev" denied the request: validation failed: the update modifies a key in "_example" which is probably not what you want. Instead, copy the respective setting to the top-level of the ConfigMap, directly below "data"
You can run `kubectl replace -f /tmp/kubectl-edit-3003085152.yaml` to try this update again.

from serving.

springCozyRock avatar springCozyRock commented on June 24, 2024

I failed to edit this.

No that should work. Are you sure you set kubernetes.podspec-nodeselector at the correct place (not in the _example section)?

oh! I didn't notice it before!

from serving.

springCozyRock avatar springCozyRock commented on June 24, 2024
  kubernetes.podspec-nodeselector: enabled
kind: ConfigMap
metadata:
  annotations:
    knative.dev/example-checksum: f2fc138e
    kubectl.kubernetes.io/last-applied-configuration: |

yes I should put it in the right place and beatles@kmaster:~$ sudo kubectl edit configmap config-features -n knative-serving configmap/config-features edited

from serving.

springCozyRock avatar springCozyRock commented on June 24, 2024

Yes. It totally worked now. I am so excited! Thanks!

from serving.

shauryagoel avatar shauryagoel commented on June 24, 2024

@ReToCode Was this changed recently? I have a cluster in which I installed knative a few months back and in its config-map config-features, I have this set-

  kubernetes.podspec-nodeselector: enabled
  kubernetes.podspec-volumes-emptydir: enabled

However, when I installed knative today in a new cluster (same knative version), the config-map does not have those fields.

from serving.

dprotaso avatar dprotaso commented on June 24, 2024

@shauryagoel someone must have edited the config map by default we don't set anything

from serving.

shauryagoel avatar shauryagoel commented on June 24, 2024

That seems improbable to me, but, I use kserve (which uses knative), and maybe that is modifying some things. I will check there.

from serving.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.