Validate ElaService object fields in the webhook. about serving

[yanweiguo]

Things to validate:

1. ElaService.Spec.Traffic should not be empty.
2. Only one of Revision or RevisionTemplate must be provided in the same ElaService.Spec.TrafficTarget.
3. ElaService.Spec.Traffic.percent should not be negative.
4. ElaService.Spec.Traffic.percent should add up to 100.
5. ElaService.Status should not be provided(or we ignore this field and mutate it to empty)

Any thoughts? Any thing else missing?

[vaikas]

I'm not sure about number 1. I could see creating a service as a placeholder that's not backed by anything.
Otherwise, looks right to me.

[evankanderson]

In particular, if an organization wants to enforce access control rules before exposing code to the internet, they may want to construct the ElaService and even poke at the underlying Istio policy before connecting it to a Revision.

…

On Wed, Feb 7, 2018 at 3:41 PM, Ville Aikas ***@***.***> wrote: I'm not sure about #1 <#1>. I could see creating a service as a placeholder that's not backed by anything. Otherwise, looks right to me. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#74 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHlyN9enZ4EUT7tKl-FTYkw6a9T6602Sks5tSjSUgaJpZM4R6IcH> .

-- Evan Anderson <[email protected]>