GithubHelp home page GithubHelp logo

Comments (5)

kneasle avatar kneasle commented on May 21, 2024 1

It's here . The rest of the related code should be reachable easily by jumping to definition a load of times.

from sapling.

stokhos avatar stokhos commented on May 21, 2024

I'd like to fix this.
where do you want the string to be printed?

from sapling.

kneasle avatar kneasle commented on May 21, 2024

The main reason we need this is so that #80 doesn't mess up the readout in the bottom right corner, as seen here:

image

What would be ideal is to have a function which takes a slice of Keys and converts them into a string by calling core::key_display::KeyDisplay::compact_string on each of them in turn. We can then use it for the bottom-right-corner readout, and the key stroke list in the keystroke log.

I think it would be tidy to add this function to KeyDisplay too.

from sapling.

stokhos avatar stokhos commented on May 21, 2024

Can you show me the code bock for the bottom-right-corner readout? I couldn't find it.

from sapling.

stokhos avatar stokhos commented on May 21, 2024

I think it would be tidy to add this function to KeyDisplay too.

Can you be more specific over this

pub fn keystrokes_to_string(keystroke_buffer: &Vec<Key>) -> String {
    keystroke_buffer
        .iter()
        .map(|x| x.compact_string())
        .collect()
}

This is my implementation, and it won't work with KeyDisplay

from sapling.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.