GithubHelp home page GithubHelp logo

Comments (6)

manuelstein avatar manuelstein commented on June 11, 2024

Backwards compatibility
The management service constitutes our API, so removing functions (without a deprecation period) means we're breaking backward compatibility. That's okayish as we haven't reached out first major release, just pointing it out.

clearWorkflowLog IIUC is a placeholder that hasn't been implemented yet with Elasticsearch. Otherwise, I think we need a solution to manage log data in Elasticsearch. AS a side note, we should consider removing log data when removing a function.

from knix.

iakkus avatar iakkus commented on June 11, 2024

You mean, if somebody has written a piece of code that utilizes the Management service APIs (besides our code, like the SDK)? Sure, we could add the appropriate responses.

clearWorkflowLog and clearAllWorkflowLogs: we can modify them to indeed the delete the logs from Elasticsearch, but I think it might be better if we could automatically delete all logs after a certain amount of time (e.g., 30 days). For example,

@paarijaat, what do you think?

from knix.

iakkus avatar iakkus commented on June 11, 2024

Implementation started on branch feature/cleanup_management.

from knix.

iakkus avatar iakkus commented on June 11, 2024

AS a side note, we should consider removing log data when removing a function.

I think perhaps removing the logs of a deleted workflow would make more sense.

from knix.

manuelstein avatar manuelstein commented on June 11, 2024

Yes, of course, as we're not executing functions but workflows.

from knix.

iakkus avatar iakkus commented on June 11, 2024

New issue to track deletion of workflow logs: #25

from knix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.