Comments (3)
@mbest - Thanks for all these PRs; I'll be caught up to the latest ones soon.
A couple notes I wanted to share:
-
Comments around new code have really helped; not just for their content, but especially because they generally provide unique searchable text that makes it easier to pare down where the changes are in the code-base.
-
I'm getting a bizarre error using thewith
binding, notably if you look at tko'sWithBindingHandler
inwith.js
, and theWithBindingHandlerFailsInexplicably
, there's something amiss in that the latter fails the testShould update "with" binding before descendant bindings
inasyncBindingBehavior.js
. However the topmost calls they make appear to be identical, and all other tests appear to pass. I dug down and there seem to be a lot more calls to the_evalIfChanged
with the version that works. The essence of the problem occurring in the test appear to be that the observables are not being triggered in the correct order.
You can try it out by running npm run watch
in the tko.binding.if
directory, and compare them by renaming the export (i.e. changing WithBindingHandlerFailsInexplicably
to WithBindingHandler
and renaming the other so there's no name conflict).
I'll keep staring at it, but since it seems to be deep in the . I was using deferUpdate
code I thought you might have some insight.createStaticChildContext
instead of createChildContext
from tko.
@mbest – I've noticed a bunch of changes to KO 3.4 since the tko fork (good work, btw); could you please add a link to each of the PRs/merges here, so we can track them and they can be incorporated without having to search through the KO issues database. Otherwise I fear we may end up with some regressions from KO 3.4 to KO 4 (/TKO 1.).
Of course, where the change is apparent please feel free to incorporate directly.
Many thanks.
EDIT: I'm sure there's an automated way to get a list of all changes merged since 3.4.0. So this issue could be solved by figuring out the git command for that. :)
from tko.
Like git log "v3.4.0"..HEAD
? I.e. just a simple listing of commits (hash, author, data date and description) since the v3.4.0
tag.
from tko.
Related Issues (20)
- Deprecate unused npm packages HOT 2
- Convert legacy documentation
- Replace hard-coded parser unicode identifier detection with RegExp HOT 3
- optionsText with a lambda value fails to resolve the function argument HOT 2
- Add preventDefault to event handler options HOT 5
- Incorrect tree with multiple 'or' operators in parser HOT 1
- Unable to load from an ES module HOT 1
- TypeError: Cannot set properties of undefined (setting 'ko') HOT 1
- Re-enable tests on builds/knockout HOT 2
- `options.bindingGlobals` can't be changed at runtime
- Revamp www.tko.io
- Fix typing of the Observable<boolean> HOT 5
- Change mappingHelpers `objectLookup` from an O(n) array to O(1) Map
- Fix the build / exports in package.json
- Build @tko/build.reference into the `tko` package
- Server side render SSR support
- How to build and import TKO-beta as a bundled library. HOT 3
- [beta1.3] ESM support HOT 3
- Writable computed out of sync
- If you have multiple || (ORs), you need parentheses, otherwise it fails silently HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tko.