GithubHelp home page GithubHelp logo

detect code conventions about knpbundles HOT 5 CLOSED

knplabs avatar knplabs commented on September 21, 2024
detect code conventions

from knpbundles.

Comments (5)

xaav avatar xaav commented on September 21, 2024

See https://github.com/symfony/symfony/blob/master/check_cs

from knpbundles.

cordoval avatar cordoval commented on September 21, 2024

So here is the plan roadmap for this feature

  • we can run php-cs-fixer tool on each bundle
  • we can annotate or grant points depending on how many warnings or messages are returned
  • email owner or such about these things

from knpbundles.

pilot avatar pilot commented on September 21, 2024

bundle code conventions is just a informative thing, I have no see sense to spent sever source for detect which code convention used by bundle, especially symfony2 bundle should follow http://symfony.com/doc/2.0/contributing/code/standards.html

it's interest task, but not in knpbundles roadmap, if you think otherwise reopen this issue.

from knpbundles.

cordoval avatar cordoval commented on September 21, 2024

can we please rather set this to RFC?

from knpbundles.

stof avatar stof commented on September 21, 2024

well, do you really want to clone all bundles to run phpcs over them ? Btw, I'm not sure KnpBundles should be responsible for it. People wanting a review of their bundle can use http://jmsyst.com/automated-code-reviews/ to have automated code reviews.

from knpbundles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.