Could not compile probe-run v0.1.6 on macOS 10.15.7 about probe-run

[andresv]

Yes same error with

cargo install --git https://github.com/knurling-rs/probe-run --branch main

however

cargo install --git https://github.com/knurling-rs/probe-run --branch pin-hidapi

works!

[andresv]

Just tried cargo install probe-run again with both 1.46 and 1.48 (i am using 1.46 because scroll does not build on later versions) and still got the same error although simple example builds nicely.

[japaric]

ok, we'll ship #114 in the next patch release to fix cargo install probe-run on macOS

there seems to be some issue with hidapi 1.2.4 on macOS but we have not been able to nail down the cause. The minimal repro from #113 (comment) failed to link for @justahero in some cases but linked fine most of the time.

I'll report the issue in the hidapi repo and see if the hidapi devs have a better idea about what's going on

[japaric]

thanks for the report. I think this may have been caused by a recent update in the hidapi crate. Could you try to build this crate for me?

$ cargo new --bin hello
$ cd hello

// src/main.rs
use hidapi as _;

fn main() {}

# Cargo.toml
[dependencies]
hidapi = "1.2.4"

$ cargo build

If that also produces a linker error then this would be a upstream issue in the hidapi crate

[japaric]

with help from @justahero we have confirmed that this is an issue in hidapi 1.2.4
this fails to link

# Cargo.toml
[dependencies]
hidapi = "1.2.4"

this works:

# Cargo.toml
[dependencies]
hidapi = "=1.2.3"

we'll report the issue upstream in a bit.
I think we can work around the problem in the next patch release of probe-run.

[andresv]

This was actually successful:

   Compiling cc v1.0.65
   Compiling pkg-config v0.3.19
   Compiling libc v0.2.80
   Compiling hidapi v1.2.4
   Compiling hello v0.1.0 (/Users/andres/Downloads/hello)
    Finished dev [unoptimized + debuginfo] target(s) in 2.11s

Tried with hidapi v1.2.4 and hidapi v1.2.3

[japaric]

@andresv was that with cargo build? and did you include use hidapi as _ in the source file? (cargo check will not perform linking. omitting the import will not link the hidapi crate)

[japaric]

was that with cargo build? and did you include use hidapi as _ in the source file?

if it still builds and links OK with those, what Rust version are you using? please report rustc -V

[andresv]

rustc 1.48.0 (7eac88abb 2020-11-16)

main.rs

use hidapi as _;

fn main() {

}

cargo.rs

[package]
name = "hello"
version = "0.1.0"
edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
#hidapi = "=1.2.3"
hidapi = "=1.2.4"

Edit:
Original error was coming from rust 1.46. I tried also this example with 1.46 and it is still ok.

[japaric]

strange! maybe cargo install probe-run will work for you now @andresv

[japaric]

if not it could be an interaction of different crates what causes the issue ...

[andresv]

I am searching which commit killed it.

[andresv]

Whaatt.
Actually if i just do:

git clone https://github.com/knurling-rs/probe-run.git
cd probe-run
# works
cargo build
# release also works
cargo build --release

[japaric]

@andresv that's probably because the repo contains a Cargo.lock file. when you do cargo install --git $something the Cargo.lock file included in the checkout is ignored.

cargo install --git $something --frozen should also work (I think it's "frozen"; it could be "locked")

[japaric]

@andresv could you try (see #114)

$ cargo install --git https://github.com/knurling-rs/probe-run --branch pin-hidapi

I'm assuming that cargo install --git https://github.com/knurling-rs/probe-run --branch main errors like in the issue description

[andresv]

Should be fixed in hidapi 1.2.5: ruabmbua/hidapi-rs@76e0f90