GithubHelp home page GithubHelp logo

dirname replacement about shellcheck HOT 2 CLOSED

koalaman avatar koalaman commented on July 22, 2024
dirname replacement

from shellcheck.

Comments (2)

koalaman avatar koalaman commented on July 22, 2024

The two are often interchangable, but in this case, for paths with trailing slashes, and in your unquoted case when the invoked name contains whitespace, the results are not identical. dirname and basename handle some edge cases well, even though it's slower and harder to use right. I'll keep it mind and see how helpful this suggestion actually is.

PS: dirname $0 is not a reliable way of getting the directory the script is in. In particular it fails when you invoke the script from $PATH.

from shellcheck.

ptman avatar ptman commented on July 22, 2024

I also think the checks on basename and dirname may be a bit aggressive

from shellcheck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.