GithubHelp home page GithubHelp logo

Comments (6)

henk717 avatar henk717 commented on June 26, 2024 1

The way retry and back work have been changed in 0.16, let me know if this now behaves as you expect.

from koboldai-client.

Atkana avatar Atkana commented on June 26, 2024

As mentioned here https://old.reddit.com/r/KoboldAI/comments/nnkbra/koboldai_update_16/gzwymv7/ it's not actually a bug, just a misalignment of user expectations. As also mentioned there, it's planned for the Retry button's functionality to change when there's options to pick, so it can be used for rerolling the multiple options (so you don't have to press submit or accept one then retry to reroll them as you currently do).

from koboldai-client.

Arcitec avatar Arcitec commented on June 26, 2024

@Atkana Thanks a lot for explaining that. It still confuses me though, because it deletes multiple chunks of the story. The regular Retry (when generation is 1), only redoes the last generated prompt. This one actually deletes the story.

It seems like this thing does:

  1. Delete the last story prompt.
  2. Re-generate the suggestions for the next prompt (in this case the user never picked one).

Therefore it's a bit of a bug. Basically it deletes the last story prompt to make room for the re-generation, but the user hasn't picked a new generation yet. 🗡️

So the bugfix would be something like "if not multi_choice_gui.is_open(): delete the last story prompt" in pseudocode.

Anyway, thank you very much for everything, I am happy to hear it's gonna be fixed.

from koboldai-client.

KoboldAI avatar KoboldAI commented on June 26, 2024

The suggested actions are not actually a part of the story until you select one and the popup list closes (meaning none of the options have been added to the actions array). If you hit Retry while the selections are up, you are retrying the last action in the actions array, which would be the line that the suggestions list is continuing. This also causes the suggestions list to disappear because those continuations are no longer valid (since you're re-rolling the action that those suggestions are continuing).
As Atkana mentioned, I'll be splitting the Retry button into two modes now depending on whether the suggestions list is up or not in order to eliminate this confusion.

from koboldai-client.

Arcitec avatar Arcitec commented on June 26, 2024

@KoboldAI Ah gotcha, that makes perfect sense. Glad to hear about the solution. :-)

from koboldai-client.

Arcitec avatar Arcitec commented on June 26, 2024

@henk717 I just noticed your message. Thank you SO MUCH. I've done a fresh reinstall of KoboldAI from the latest git and trying it out right now. It's absolutely PERFECT! "Back" closes the multi-selection suggestions without losing the story. "Retry" generates new suggestions without losing the story. I even tried editing the current story (while the suggestions were open) and then hitting Retry, and it successfully saw the edits and gave new suggestions without losing the story.

You've done it. It's perfect now! <3 Thank you so much.

from koboldai-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.