Comments (9)
Fixed these (had to make sure rack.hpp includes are always done first.
But build now fails because setNextCableColor is removed....
from squinkyvcv-main.
All fixed, new codeset uploaded.
from squinkyvcv-main.
still doesn't compile for me:
In file included from src/ctrl/SemitoneDisplay.h:5,
from src/CHBModule.cpp:1:
../../include/rack.hpp:10:2: error: #error "Plugins must only include rack.hpp. Including other Rack headers is unsupported."
10 | #error "Plugins must only include rack.hpp. Including other Rack headers is unsupported."
| ^~~~~
from squinkyvcv-main.
Interesting, as my automated github builds for all 3 platforms built succesfully. They all build new fresh installs so it must be something in your environment.
from squinkyvcv-main.
yeah, ok. right. I probably don't know how to build plugins.
If I put #include "rack.hpp" at the top of each module that doesn't build the problem goes away.
from squinkyvcv-main.
I hope your response was/is cynical, and you were not offended by my response. If so, that wasn't want I meant as of course I respect your work a lot and am in no way doubting your competences.
It is not ' just' putting the include on top of the file where it is included, but you also have to make sure that file gets included first in the other files.
Actually, this whole thing doesn't really make sense to me, as it states you shouldn't include other rack files , only the rack.hpp. And as far as I know, you never break that rule.
But it solves the problem, but maybe I should raise it as an issuie to Andrew.
from squinkyvcv-main.
Yes, I do "violate" that rule. Which, btw, it a new rule, and did not exist before this week. You can find some places where I did this if you grep for #include.*/
I see a few - not sure which are the culprits. Here's an example:
#ifdef __PLUGIN
#include "engine/Param.hpp"
#include "engine/Port.hpp"
#endif
And, yes, I did find your response dismissive. As you know, "works for me" is an ancient cliche used mostly by lazy programmers. You did not seem interested at all in what the problems might be. You might have started out by trying to find out what might be going on.
from squinkyvcv-main.
Rereading my answer I understand my response could have been interpreted as "works for me" but that wasn't what I meant. I used interesting, which to me means I am interested and want to find out what is going on. As I wrote the code release I did is building without errors on all 3 platforms, so it is weird it is not working for you. Unless you didn't pull the latest version from my repo. That wasn't clear from your earlier answer.
Next poi t is if my solution is the perfect one. No I don't think it is, but it is working for now, and as I am fixing other issues as well I will work on a hopefully better release in parallel.
Again , the response wasn't meant to be dismissive.
from squinkyvcv-main.
ok. Hopefully at some point in the future these plugins will build for me.
from squinkyvcv-main.
Related Issues (20)
- Mixer8 mute/solo randomize/initialize behavior seems wrong HOT 1
- Undo doesn't work in multiple cases HOT 4
- Feature request: next/prev SFZ file
- Seq++ grid time signature feature request HOT 1
- Seq++ feature requests modes HOT 3
- Seq++ new user experiance HOT 1
- Seq++ note input bug HOT 5
- Compiling with Rack 2.2.0 using gcc 11.3 fails on simde instructions HOT 2
- No arm64 ... HOT 5
- Please consider changing the license to GPLv3+ (GNU General Public License v3.0 or later) HOT 5
- Funcional VCO nanV on saw output
- Uninitialized variable in DrumTriggerModule HOT 1
- Build error : ./dsp/third-party/falco/DspFilter.h:102:17: error: 'int64_t' does not name a type HOT 1
- Pluign fails to compile on macOS arm64 platform HOT 4
- no retrigger input in SFZ player
- Comp does not output audio at launch until Mix knob is moved from 0
- get build errors in windows now HOT 3
- seq++ doesn't seem to load my seq_user_keys.json file
- seq++ playhead not visible HOT 2
- Request: Mixer 8, cv input for all mute
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from squinkyvcv-main.