Switch statement about objective-c-style-guide

In my life coding, I always put a comment where a break would be that reads

// intentionally omitted break

I'd vote something like that.

Sent from my iPhone

On Nov 8, 2013, at 3:06 AM, Matthijs Hollemans [email protected] wrote:

How to format a switch statement?

How to point out that a case falls through?

—
Reply to this email directly or view it on GitHub.

[gregheo]

@elephantronic I love the phrase "life coding"!

I go with a boring /* fallthrough */ myself. I agree, this should always been commented if you mean to leave out the break.

switch (foo) {
case 1:
  // stuff
  // *** fallthrough! ***
case 2:
  // moar stuff
  break;
default:
}

[icanzilb]

hm .. I think I have never in my life had a switch that lets cases fall through ... I find it confusing and easy to miss out on when debugging.

I have either completely overlapping cases:

case 1: case 2: case 5:
// stuff
break;

or

case 1:
//stuff 1
break;
case 2
//stuff 2
break;

etc.

[hollance]

I suggest we always include a default: case.

switch (condition) {
  case 1: {
    // ...
    break;
  }
  case 2: {
    // ...
    break;
  }
  default: {
    // ...
    break;
  }
}

I don't think the braces are necessary all the time, but definitely when a case contains more than one line.

[funkyboy]

More over: if you are switching on an enumeration default is not needed.

On Sat, Nov 9, 2013 at 10:15 AM, Matthijs Hollemans <
[email protected]> wrote:

I suggest we always include a default: case.

switch (condition) {
case 1: {
// ...
break;
}
case 2: {
// ...
break;
}
default: {
// ...
break;
}}

I don't think the braces are necessary all the time, but definitely when a
case contains more than one line.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-28123255
.

Cesare Rocchi
http://studiomagnolia.com

If you are switching on an enumeration, it's recommended practice to not include a default case because the compiler cannot warn you for unhandled values.

Sent from my iPhone

On Nov 9, 2013, at 4:47 AM, Cesare [email protected] wrote:

More over: if you are switching on an enumeration default is not needed.

On Sat, Nov 9, 2013 at 10:15 AM, Matthijs Hollemans <
[email protected]> wrote:

I suggest we always include a default: case.

switch (condition) {
case 1: {
// ...
break;
}
case 2: {
// ...
break;
}
default: {
// ...
break;
}}

I don't think the braces are necessary all the time, but definitely when a
case contains more than one line.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-28123255
.

Cesare Rocchi
http://studiomagnolia.com
—
Reply to this email directly or view it on GitHub.

[ndubbs]

Could someone add this as a new section after "Enumerated Types," then send a pull request?