The cmd main server graceful shutdown code seems does not meet expectations? about zadig

[KevinWu0904]

I think it really doesn't work.

When the main goroutine exit, all the process will exit. It remains no chance to execute the sub goroutine's shutdown, right ?

Maybe we can change the code like:

package main

import (
	"context"
	"log"
	"net/http"
	"os/signal"
	"syscall"
	"time"
)

func main() {
	ctx, _ := signal.NotifyContext(context.Background(), syscall.SIGTERM, syscall.SIGINT)

	http.HandleFunc("/ping", ping)
	server := &http.Server{Addr: ":6666", Handler: nil}

	go func() {
		if err := server.ListenAndServe(); err != nil {
			log.Printf("Failed to start http server, error: %s", err)
			return
		}
	}()

	<-ctx.Done()

	// do some cleanup things

	t, _ := context.WithTimeout(context.Background(), 5*time.Second)

	if err := server.Shutdown(t); err != nil {
		log.Printf("Failed to stop server, error: %s", err)
	}
}

func ping(w http.ResponseWriter, r *http.Request) {
	time.Sleep(4 * time.Second)
	_, _ = w.Write([]byte("success"))
}

[nanzm]

@KevinWu0904 Yes, yours is right ！

[27149chen]

@nanzm thank you for pointing out this, @KevinWu0904 thank you for your solution. It will appear in opensource version soon

[27149chen]

fixed in #46