GithubHelp home page GithubHelp logo

Comments (4)

TimWhiting avatar TimWhiting commented on June 9, 2024 1

Actually this is now fixed on dev.

from koka.

anfelor avatar anfelor commented on June 9, 2024

@daanx This is due to the identifier tail in -> repro/min-by-rec<a>(tail, ordering, default, (ordering(x)), x); being parsed as the tail fip keyword. In this line the try parseFip parser succeeds while consuming input (due to the catch-all case of a tail but non-fip function) Then, the next line fails but the try keyword does not span that line. I would suggest moving the try keyword to span both the parseFip and the dockeyword "fun" in the parser.

from koka.

anfelor avatar anfelor commented on June 9, 2024

Great, I can confirm that this is fixed! There is another occurrence of try parseFip in inlineDefSort -- while there is currently no danger of this going wrong, I would recommend fixing that as well since confusingly try parseFip == parseFip. Should I push a fix?

from koka.

TimWhiting avatar TimWhiting commented on June 9, 2024

Let's avoid that change for now. Daan has changed some parsing on the branch dev-overload, and we should wait for that to be merged.

from koka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.