[FreeTDS][SQL Server]Invalid string or buffer length about odbc-rs

[Koka]

@bbigras It's very strange. I've finally setup dockerized version of MSSQL for Linux on my Mac and I've run your code for 100 times (with latest odbc-rs 0.9.0) in a loop and everything is fine, no errors, 10605 is returned every time

[pacman82]

Sounds like we messed up in our unsafe code. A backtrace would be helpful.

[bbigras]

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: State: HY090, Native error: 0, Message: [FreeTDS][SQL Server]Invalid string or buffer length', /checkout/src/libcore/result.rs:860:4
stack backtrace:
   0: std::sys::imp::backtrace::tracing::imp::unwind_backtrace
             at /checkout/src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at /checkout/src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at /checkout/src/libstd/sys_common/backtrace.rs:60
             at /checkout/src/libstd/panicking.rs:380
   3: std::panicking::default_hook
             at /checkout/src/libstd/panicking.rs:396
   4: std::panicking::rust_panic_with_hook
             at /checkout/src/libstd/panicking.rs:610
   5: std::panicking::begin_panic
             at /checkout/src/libstd/panicking.rs:571
   6: std::panicking::begin_panic_fmt
             at /checkout/src/libstd/panicking.rs:521
   7: rust_begin_unwind
             at /checkout/src/libstd/panicking.rs:497
   8: core::panicking::panic_fmt
             at /checkout/src/libcore/panicking.rs:71
   9: core::result::unwrap_failed
             at /checkout/src/libcore/macros.rs:31
  10: <core::result::Result<T, E>>::unwrap
             at /checkout/src/libcore/result.rs:738
  11: test_odbc::main
             at src/main.rs:292
  12: __rust_maybe_catch_panic
             at /checkout/src/libpanic_unwind/lib.rs:98
  13: std::rt::lang_start
             at /checkout/src/libstd/panicking.rs:458
             at /checkout/src/libstd/panic.rs:361
             at /checkout/src/libstd/rt.rs:61
  14: main
  15: __libc_start_main
  16: _start

[bbigras]

Any progress on this?

[Koka]

@bbigras I'm afraid not much as I've had almost no free time in last few month to check this further.

[Koka]

Note to myself: looks like bind param is broken at

odbc-rs/src/statement/input.rs

Line 74 in 35f90a7

len_buf_ptr.as_mut_ptr() as *mut ffi::SQLLEN, // str len or ind ptr

- odbc spec states that this buffer must be alive at the time of statement execution, and for now it's not true. Looks like awful use-after-free bug :(