Gitlab CI is not recognizing the git command used to retrieve branch name about nx-sonarqube

[tstackhouse]

Opened PR #21 to omit the param if the option is false or unset.

[koliveira15]

@tstackhouse your PR has been published under version 2.1.1

[tstackhouse]

Sweet! Thank you for pulling in my change. I’ll give it a try on Monday :)

[tstackhouse]

Just to follow up, I pulled in the update and it worked like a charm :D The PR detection is now working perfectly in GitHub CI. Thanks again!

[ak274]

Following might help to understand why its not working in Gitlab CICD.
https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4557

[koliveira15]

@ak274 seems like the issue is specific to Gitlab runner. Handling every type of CI environment is not in scope for the plugin. I would be open to changing the branches parameter to branch. That way consumers can pass in their own branch name, respective of their CI environment.

[ak274]

I have observed that if you remove sonar.branch.name param from the scanner function altogether.. the GitLab CI automatically detect branch name and pull requests.

[tstackhouse]

This behaviour also happens in GitHub's CI/CD pipelines. Running with branches: false the scanner tries to autoconfigure, but fails because sonar.branch.name is still passed, even though the value is '', resulting in the following:

...
INFO: Load project branches
INFO: Load project branches (done) | time=108ms
INFO: Load project pull requests
INFO: Load project pull requests (done) | time=113ms
INFO: Load branch configuration
INFO: Detected branch/PR in 'GitHub Action'
INFO: Auto-configuring pull request '####'
INFO: ------------------------------------------------------------------------
INFO: EXECUTION FAILURE
INFO: ------------------------------------------------------------------------
INFO: Total time: 15.413s
ERROR: Error during SonarScanner execution
ERROR: A pull request analysis cannot have the branch analysis parameter 'sonar.branch.name'
ERROR: 
INFO: Final Memory: 6M/24M
INFO: ------------------------------------------------------------------------