GithubHelp home page GithubHelp logo

Comments (3)

kolodny avatar kolodny commented on May 23, 2024

That would be correct if the argument passed in always returned functions which isn't something that the function handles.

function value(val) {
  if (typeof val === 'function') return value(val());
  return val;
}
var fn = function() { return fn; };
value(fn); // stackoverflow

Using an iterative approach would just cause this to hang:

function value(val) {
  var current = val;
  while (typeof current === 'function') current = current();
  return current;
}
var fn = function() { return fn; };
value(fn); // hangs, run at your own risk

You may think there's an argument to make for the recursive approach since you can have a try-catch block around it if it is an invalid input, but for the same price you can have a loop counter in the iterative approach and throw once it breaks a threshold.

Let me know if there's anything I missed or misunderstood, and I'll reopen this issue.

from exercises.

zg avatar zg commented on May 23, 2024

This doesn't hang and it also passed all tests:

module.exports = value;

function value(val) {
  while(typeof val === 'function')
    val = val();
  return val;
}

from exercises.

kolodny avatar kolodny commented on May 23, 2024

Sure. so does this

module.exports = value;

function value(thing) {
  return typeof thing === 'function' ? value(thing()) : thing;
}

It doesn't cause a stack overflow because it has an termination condition

from exercises.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.