Comments (3)
That would be correct if the argument passed in always returned functions which isn't something that the function handles.
function value(val) {
if (typeof val === 'function') return value(val());
return val;
}
var fn = function() { return fn; };
value(fn); // stackoverflow
Using an iterative approach would just cause this to hang:
function value(val) {
var current = val;
while (typeof current === 'function') current = current();
return current;
}
var fn = function() { return fn; };
value(fn); // hangs, run at your own risk
You may think there's an argument to make for the recursive approach since you can have a try-catch
block around it if it is an invalid input, but for the same price you can have a loop counter in the iterative approach and throw once it breaks a threshold.
Let me know if there's anything I missed or misunderstood, and I'll reopen this issue.
from exercises.
This doesn't hang and it also passed all tests:
module.exports = value;
function value(val) {
while(typeof val === 'function')
val = val();
return val;
}
from exercises.
Sure. so does this
module.exports = value;
function value(thing) {
return typeof thing === 'function' ? value(thing()) : thing;
}
It doesn't cause a stack overflow because it has an termination condition
from exercises.
Related Issues (20)
- Create gh-page HOT 2
- link in "curry" prompt goes to incorrect article HOT 1
- Add levels HOT 1
- Test suite for `throttle` appears to be incorrect HOT 5
- The problem of the 4th test suite for `throttle` HOT 2
- Incorrect throttle definition HOT 7
- a separate repo or folder for solutions could be great HOT 1
- Once and memoize HOT 3
- Is there any order to be followed to approach these exercises? HOT 2
- Example "sort sorts better than n^2" doesn't actually verify the algorithm's time complexity HOT 1
- sinon hack Date Object prevent throttle get passed HOT 2
- throttle-promises expectedHistory seems to be wrong HOT 1
- flipjs
- You could actually put these tests at codewars.com HOT 1
- Lookup count in binary-search test is not correct HOT 3
- memoize test does not check return value
- Include use-case references
- I'm doing itοΌ show my code
- Error with command: npm test HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from exercises.