GithubHelp home page GithubHelp logo

Comments (12)

ahmadnassri avatar ahmadnassri commented on July 29, 2024

👍 was holding back since more are coming ... though for ocaml doubt there will be (didn't even anticipate we'll have that one on launch)

from apiembed.

montanaflynn avatar montanaflynn commented on July 29, 2024

Couldn't we add the logic of "If there's more than one, show up" instead of doing it on a per target basis?

from apiembed.

ahmadnassri avatar ahmadnassri commented on July 29, 2024

yeah, that's what i'll be doing ...

from apiembed.

SGrondin avatar SGrondin commented on July 29, 2024

There won't be another one for OCaml, you can just remove the All checkbox, but I think it's important to keep the "Cohttp" somewhere because it's important information.

from apiembed.

ahmadnassri avatar ahmadnassri commented on July 29, 2024

I think a design update is needed, I wanna be able to show the "library" info somewhere, link to source ... @jitachi

from apiembed.

montanaflynn avatar montanaflynn commented on July 29, 2024

Should still remove it for now because it's really weird. That OCaml uses a library needs to be apparent inside the code or embedded widget since people will be seeing it embedded in another website. A code comment at the top would be sufficient, just like we do with Unirest on mashape.

from apiembed.

ahmadnassri avatar ahmadnassri commented on July 29, 2024

@montanaflynn yeah, I think we're saying the same thing, I mean for inside the widget, not the site, be nice to give credit to the library source & even the contributing author for each target converter

something along the lines of:

Unirest support by @therebelrobot

from apiembed.

ahmadnassri avatar ahmadnassri commented on July 29, 2024

something along those lines:

image

from apiembed.

ahmadnassri avatar ahmadnassri commented on July 29, 2024

maybe for libraries the text would be: COhttp support by ... since the language name is already obvious in the tab

from apiembed.

montanaflynn avatar montanaflynn commented on July 29, 2024

I was mostly replying to @SGrondin to make sure the library is mentioned inside the embedded widget.

So in the top of his code he would put something like:

(* Requires https://github.com/mirage/ocaml-cohttp *)

and we would do the same for Unirest and other non-native targets.

from apiembed.

ahmadnassri avatar ahmadnassri commented on July 29, 2024

ah, code comments, yes those are good.

from apiembed.

SGrondin avatar SGrondin commented on July 29, 2024

I'll add a comment.

from apiembed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.