GithubHelp home page GithubHelp logo

Comments (5)

montanaflynn avatar montanaflynn commented on July 29, 2024

Is there a benefit to this approach besides one less line? The httpsnippet project is using the client for a timeout option and I'll probably add a redirect option as well.

from apiembed.

DanielHeath avatar DanielHeath commented on July 29, 2024

Nothing wrong with it, it's just not idiomatic go (unless you use the client to do something).

from apiembed.

montanaflynn avatar montanaflynn commented on July 29, 2024

Thanks for the input. Like I said the underlying library has a timeout option so that's why it's there, I might make it as you suggest for when the option is not invoked or maybe just set a default timeout.

from apiembed.

ahmadnassri avatar ahmadnassri commented on July 29, 2024

@Montana you could also make two separate implementations and let the user decide which they'd like to use.

also, this would be better suited as a discussion on https://github.com/Mashape/httpsnippet

from apiembed.

montanaflynn avatar montanaflynn commented on July 29, 2024

Closed with Kong/httpsnippet@45a0e36

from apiembed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.